Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java API invocation flexibility #18078

Merged
merged 10 commits into from
Mar 18, 2024

Conversation

l3ender
Copy link
Contributor

@l3ender l3ender commented Mar 11, 2024

Resolves #17932 by adding generic API stub methods that can be called for scenarios where the API returns URL/links to invoke additional endpoints.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@l3ender l3ender marked this pull request as ready for review March 12, 2024 01:48
@l3ender
Copy link
Contributor Author

l3ender commented Mar 12, 2024

@wing328 - would you mind taking a look at this PR when able, and letting me know any thoughts/feedback? Thank you!

@wing328
Copy link
Member

wing328 commented Mar 12, 2024

cc
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)

@wing328
Copy link
Member

wing328 commented Mar 18, 2024

thanks for the PR and overall it looks good.

@wing328 wing328 merged commit b59957a into OpenAPITools:master Mar 18, 2024
71 checks passed
@l3ender l3ender deleted the java-api-invocation-flexibility branch March 18, 2024 13:52
zapodot pushed a commit to zapodot/openapi-generator that referenced this pull request Mar 21, 2024
* add direct invocation methods for java (httpclient)

* add direct invocation methods for java (resttemplate)

* handle methods only if endpoints exist for api client

* preserve previous newline to minimize changes

* update httpclient/resttemplate samples

* add common methods in base class

* regenerate samples with base class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQ] Make API call to URL returned in response
2 participants