fix: Don't apply spread operator to strings #18185
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some incorrect assumptions on #18154 and as a result the generator ends up applying the spread operator on a string, which is the wrong behavior.
This PR fixes that replacing the spread operation with a
||
. This makes the API client have the correct behavior and properly pass the Enum value forward with the correct type.This doesn't fix the case when
discriminator
is being used, and I don't know the use case of that or how it works, so I won't touch that code.I'm not too familiar with the internals, so some guidance in adding tests for this would be a nice extra for this PR.
Testing instructions
I tested this using the APIs from my project.
Relevant details:
oneOf
merging multiple Enums (example on fix: Fix schema generation foroneOf
when using TS-FETCH client #18154).PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)