Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix[kotlin]: only use data class when it has constructor vars #18202

Conversation

rescribet
Copy link
Contributor

Ran into the issue #14710 as well. The kotlin-spring template is very similar but includes a conditional using #hasVars which controls whether a regular or a data class is generated.

AFAICT that variable comes in somewhere via the CodegenModel since the KotlinSpringServerCodegen doesn't specify it explicitly.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples...
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Comittee members: @jimschubert, @dr4ke616, @karismann, @Zomzog, @andrewemery, @4brunu, @yutaka0m, @stefankoppier

@wing328
Copy link
Member

wing328 commented Mar 23, 2024

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328 wing328 added this to the 7.5.0 milestone Mar 23, 2024
@wing328 wing328 merged commit 2916be0 into OpenAPITools:master Mar 23, 2024
14 checks passed
@wing328
Copy link
Member

wing328 commented Mar 23, 2024

lgtm, thanks for the PR

have a nice weekend

@rescribet rescribet deleted the issues/14710-data-classes-must-have-one-member branch June 12, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants