-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert back to junit4 #18786
Merged
Merged
Revert back to junit4 #18786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wing328
commented
May 29, 2024
{{#required}}{{^isReadOnly}}@NotNull {{/isReadOnly}}{{/required}}{{#isContainer}}{{^items.isPrimitiveType}}{{^items.isDate}}{{^items.isDateTime}}{{^items.isString}}{{^items.isFile}}{{^items.isEnumOrRef}}@Valid {{/items.isEnumOrRef}}{{/items.isFile}}{{/items.isString}}{{/items.isDateTime}}{{/items.isDate}}{{/items.isPrimitiveType}}{{/isContainer}}{{^isContainer}}{{^isPrimitiveType}}{{^isDate}}{{^isDateTime}}{{^isString}}{{^isFile}}{{^isEnumOrRef}}@Valid {{/isEnumOrRef}}{{/isFile}}{{/isString}}{{/isDateTime}}{{/isDate}}{{/isPrimitiveType}}{{/isContainer}}{{>beanValidationCore}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CREKD127 FYI. I've added back the isReadonly check in this PR (latest master)
Philzen
added a commit
to Philzen/openapi-generator
that referenced
this pull request
May 29, 2024
This reverts commit 2471ba2.
wing328
pushed a commit
that referenced
this pull request
Jun 1, 2024
* Revert "Revert back to junit4 (#18786)" This reverts commit 2471ba2. * Make junit engine execute TestNG test cases * Fix failing test and use tempDir's for test code generation * Make test fail with helpful info in case generator throws exception * Suppress error output from TestUtils * Remove transitive junit4 dependency * Sync guava-testlib version with guava version * Add hint regarding alternative for guava-testlib's FakeTicker
welshm
pushed a commit
to welshm/openapi-generator
that referenced
this pull request
Jun 5, 2024
* Revert "Revert back to junit4 (OpenAPITools#18786)" This reverts commit 2471ba2. * Make junit engine execute TestNG test cases * Fix failing test and use tempDir's for test code generation * Make test fail with helpful info in case generator throws exception * Suppress error output from TestUtils * Remove transitive junit4 dependency * Sync guava-testlib version with guava version * Add hint regarding alternative for guava-testlib's FakeTicker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
revert to junit4 (from junit5) to that both junit and testng tests are run when building the project
FYI @OpenAPITools/generator-core-team
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)