Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java-retrofit2] Support payload for DELETE method #19056

Merged

Conversation

vbauer
Copy link
Contributor

@vbauer vbauer commented Jul 2, 2024

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@vbauer
Copy link
Contributor Author

vbauer commented Jul 2, 2024

HTTP specification (https://www.rfc-editor.org/rfc/rfc7231#section-4.3.5):

A payload within a DELETE request message has no defined semantics; sending a payload body on a DELETE request might cause some existing implementations to reject the request.

As I see, it means that we can use payload in delete methods. Retrofit2 supports this features with another specific annotation

@vbauer
Copy link
Contributor Author

vbauer commented Jul 2, 2024

@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @martin-mfg

Hello! Could you please review my PR?

@wing328
Copy link
Member

wing328 commented Jul 3, 2024

thanks for the PR

lgtm.

@wing328 wing328 merged commit 9c4664a into OpenAPITools:master Jul 3, 2024
64 checks passed
@wing328 wing328 added this to the 7.8.0 milestone Jul 3, 2024
vbauer added a commit to vbauer/openapi-generator that referenced this pull request Jul 7, 2024
wing328 pushed a commit that referenced this pull request Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants