Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qt-cpp] Remove Qt support before Qt 5.15.2 #19164

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

MartinDelille
Copy link
Contributor

There is some Qt version check in the generated code. I propose to drop pre Qt 5.15.2 to make the maintenance easier.

Ping @ravinikam @stkrwork @etherealjoy @muttleyxd

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 added this to the 7.8.0 milestone Jul 16, 2024
@wing328 wing328 merged commit 49e3318 into OpenAPITools:master Jul 16, 2024
18 checks passed
@MartinDelille MartinDelille deleted the qt-remove-pre-qt-5-15-2 branch July 18, 2024 13:59
m33rc47 added a commit to m33rc47/openapi-generator that referenced this pull request Oct 9, 2024
This is a follow-up pull request for [OpenAPITools#19164] (OpenAPITools#19164), which removes the further handling of older Qt versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants