Add F# Functions server generator #3933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test fix fix template paths replace giraffe sample
|
FYI. I've pushed 70fe969 to update the doc so as to fix the CircleCI failure. |
|
Let's go ahead with this and get some feedback from the F# community. |
|
Great, thanks @wing328! Also worth mentioning you're doing a bang up job with the project, seems to be growing like crazy and you're still super responsive. Well done! |
|
@nmfisher thanks for the compliment. The credit goes to the awesome community including you. Many companies (big corp, startups, etc) are using it in production and start contributing back. It just gets better and better everyday. |
wing328
reviewed
Sep 25, 2019
| @@ -40,8 +40,17 @@ module UserApiHandlerTestsHelper = | |||
| let mutable CreateUsersWithArrayInputExamples = Map.empty | |||
| let mutable CreateUsersWithArrayInputBody = "" | |||
|
|
|||
| CreateUsersWithArrayInputBody <- WebUtility.HtmlDecode "" | |||
| CreateUsersWithArrayInputExamples <- CreateUsersWithArrayInputExamples.Add("", CreateUsersWithArrayInputBody) | |||
| CreateUsersWithArrayInputBody <- WebUtility.HtmlDecode "{ | |||
There was a problem hiding this comment.
@nmfisher I notice the use of WebUtility.HtmlDecode here. What if we use {{{...}}} (original) instead of {{...}} (HTML escaped)?
jimschubert
added a commit
that referenced
this pull request
Sep 30, 2019
* master: (207 commits) Add missing enum processing in C++ codegen, already present for Qt5 (#3986) [C++] [Pistache] Removed deprecated warnings (#3985) [C++][Pistache] Simplified model template (#3417) add go oas3 petstore to ensure up-to-date (#3979) replace gitter with slack in the doc (#3977) Fix wrong variable name in LessThan and LessThanOrEqual asserts (#3971) #3957 - Removed hardcoded baseUrl (#3964) Regenerate go openapi3 samples (#3975) [rust] Make it easier to test rust client generator (#3543) Fix issue3635 (#3948) add gradle repository (#3867) [java] allow to use setArtifactVersion() programmatically (#3907) Add a link to DevRelCon SF 2019 (#3961) Add a link to a medium blog post (#3960) update maven-compiler-plugin version (#3956) fix generateAliasAsModels in default generator (#3951) Implement BigDecimal to Decimal in swift4 for currency data as type=string format=number (#3910) Add F# Functions server generator (#3933) [python-experimental] generate model if type != object if enums/validations exist (#2757) [scala] add [date-time] field to codegen unit test (#3939) ...
Jesse0Michael
pushed a commit
to Jesse0Michael/openapi-generator
that referenced
this pull request
Oct 3, 2019
* cherry pick F# Functions generator test fix fix template paths replace giraffe sample * update doc
jimschubert
added a commit
that referenced
this pull request
Oct 4, 2019
* master: (110 commits) [golang] Regenerate all go samples (#3988) Better tests for string (number) (#3953) Add missing enum processing in C++ codegen, already present for Qt5 (#3986) [C++] [Pistache] Removed deprecated warnings (#3985) [C++][Pistache] Simplified model template (#3417) add go oas3 petstore to ensure up-to-date (#3979) replace gitter with slack in the doc (#3977) Fix wrong variable name in LessThan and LessThanOrEqual asserts (#3971) #3957 - Removed hardcoded baseUrl (#3964) Regenerate go openapi3 samples (#3975) [rust] Make it easier to test rust client generator (#3543) Fix issue3635 (#3948) add gradle repository (#3867) [java] allow to use setArtifactVersion() programmatically (#3907) Add a link to DevRelCon SF 2019 (#3961) Add a link to a medium blog post (#3960) update maven-compiler-plugin version (#3956) fix generateAliasAsModels in default generator (#3951) Implement BigDecimal to Decimal in swift4 for currency data as type=string format=number (#3910) Add F# Functions server generator (#3933) ...
|
@nmfisher thanks for the PR, which has been included in the v4.1.3 release: https://twitter.com/oas_generator/status/1180123829626003456 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.Description of the PR
This PR adds a server stub generator for F#/Azure Functions, based closely on the F#/Giraffe generator I previously submitted/merged.
To maximize code re-use between the Giraffe and Azure Functions generator, I made a few changes to the existing F# generator classes. None of these should break backwards compatibility though.