Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Additional annotations for model type (class level annotations) #4026

Merged

Conversation

borsch
Copy link
Member

@borsch borsch commented Oct 2, 2019

PR checklist

  • [+] Read the contribution guidelines.
  • [+] Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.
  • [+] Filed the PR against the correct branch: master, 4.1.x, 5.0.x. Default: master.
  • [+] Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

#4025

I want to have an ability to specify my custom annotations for model type. This will allow to add annotations from tools like lombok or in case if you have you custom AnnotationProcessor with own annotation

@borsch borsch force-pushed the issue-4025-custom-java-annotations branch from 4dfca44 to 2dd5cfd Compare October 3, 2019 08:00
@borsch borsch force-pushed the issue-4025-custom-java-annotations branch from 2dd5cfd to d4a6479 Compare November 28, 2019 15:19
@borsch
Copy link
Member Author

borsch commented Nov 28, 2019

@wing328 @jimschubert could you please look at this?

@borsch borsch closed this Dec 2, 2019
@borsch borsch reopened this Dec 2, 2019
Copy link
Member

@jimschubert jimschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. Just a few minor comments.

bin/java-petstore-feign-10x.sh Outdated Show resolved Hide resolved
update_all.sh Outdated Show resolved Hide resolved
@borsch borsch force-pushed the issue-4025-custom-java-annotations branch from c358b65 to c3150e5 Compare December 3, 2019 11:12
@jimschubert jimschubert added this to the 4.2.3 milestone Dec 3, 2019
@jimschubert jimschubert merged commit ba3af50 into OpenAPITools:master Dec 3, 2019
@jimschubert
Copy link
Member

@borsch looks great! Thanks!

cc for visibility @cbornet @wing328

@wing328 wing328 changed the title [#4025] custom java annotations [Java] Additional annotations for model type (class level annotations) Jan 31, 2020
@borsch borsch deleted the issue-4025-custom-java-annotations branch January 30, 2021 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants