-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dart][dio] add dateLibrary options ( core, timemachine ) #4716
Conversation
Signed-off-by: Minsu Lee <amond@amond.net>
Signed-off-by: Minsu Lee <amond@amond.net>
57a47fc
to
7361062
Compare
ded9d7d
to
beab4ef
Compare
Please run the following to update the doc as well
|
@wing328 I have updated the documentation. |
Thanks @amondnet! So guys I don’t use this generator or know much about it. Personally I think we should be working toward a single dart generator with options rather than continuing to diverge. I respect that others have different opinions but that is where I want to be spending my limited time rather than trying to stay on top of the different generators. I’m wondering if, rather than getting silence from the technical committee, @wing328 what do you think about asking @athornz and @amondnet if they want to be the technical committee for the dart-dio generator (and would you guys want to?). Thanks, sorry I'm not more help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I think this is a nice addition to the generator
@nickmeinhold I'm happy to be added to the committee for dart dio. |
@nickcmaynard Yes, I would like to join the committee. |
This pr adds
dateLibrary
option and simple test todart-dio
generator.dateLibrary
has two options.dart:core
, (default), not handled properlydate
,date-time
format; [BUG] Dart code generator does not support date format for string #2696 I will make a new PR on this.If
dateLibrary
istimemachine
,input
output
@ircecho @swipesight @jaumard @nickmeinhold
--
PR checklist
./bin/
(or Windows batch scripts under.\bin\windows
) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the code or mustache templates for a language ({LANG}
) (e.g. php, ruby, python, etc).master
,4.3.x
,5.0.x
. Default:master
.