Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[r] Fixing the CRAN submission issues #4828

Merged
merged 2 commits into from
Dec 19, 2019

Conversation

saigiridhar21
Copy link
Contributor

@saigiridhar21 saigiridhar21 commented Dec 18, 2019

  • Fixing the CRAN submission issues that will be complained, while releasing the package on CRAN package manager.

Issue 1: Dependence on the R version should not specify the patch version.
Issue 2: Ignoring the unrequired files and directories from being added to the R package.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@Ramanth

@auto-labeler
Copy link

auto-labeler bot commented Dec 18, 2019

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@Ramanth
Copy link
Contributor

Ramanth commented Dec 18, 2019

LGTM

@wing328 wing328 added this to the 4.2.3 milestone Dec 19, 2019
@wing328 wing328 merged commit e6e919f into OpenAPITools:master Dec 19, 2019
@saigiridhar21 saigiridhar21 deleted the fix/r/cran-issues branch December 19, 2019 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants