-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java] Fixes Spring generator devaultValues for int64/float/double #4969
Merged
wing328
merged 9 commits into
OpenAPITools:master
from
spacether:issue_1226_fix_defaultValue
Jan 14, 2020
Merged
[Java] Fixes Spring generator devaultValues for int64/float/double #4969
wing328
merged 9 commits into
OpenAPITools:master
from
spacether:issue_1226_fix_defaultValue
Jan 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…defaults, adds testDefaultValuesFixed Adds the test testDefaultValuesFixed
spacether
changed the title
Fixes spring generator devaultValues for int64/float/double
[Java] Fixes spring generator devaultValues for int64/float/double
Jan 10, 2020
spacether
changed the title
[Java] Fixes spring generator devaultValues for int64/float/double
[Java] Fixes Spring generator devaultValues for int64/float/double
Jan 10, 2020
wing328
reviewed
Jan 13, 2020
modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/SpringCodegen.java
Outdated
Show resolved
Hide resolved
wing328
reviewed
Jan 13, 2020
modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/SpringCodegen.java
Outdated
Show resolved
Hide resolved
wing328
reviewed
Jan 13, 2020
…arameter defaultValues, updates tests
Tested again and no longer encounter the issue. |
wing328
approved these changes
Jan 14, 2020
Exactly the same problem occurs with the jaxrs-cxf generator. In the templates_@DefalutValue_ annotations are generated based on the model defaultvalue parameter. This results in a @DefaultValue with a postfix which results in invalid default values. |
@fooo I wonder if you can file a PR with a similar fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1226
That issue describes that when we have an in64, float, or double CodegenParameter, the string defaultValue includes unneeded suffix characters l,f, or d. Those suffixes were added by AbstractJavaCodegen because that generator assumed that those default values would be used as java values of the correct type. Instead, the spring generator uses String type default values for CodegenParameter only. Typically those values are handled with parseLong/parseFloat/parseDouble etc which fail if the value includes a character suffix.
This update keeps the suffixes on CodegenProperties because templates use those defaultValues as Long/Float/Double literal values.
CodegenProperty defaultValues:
For CodegenParameter we now use values which lack the suffix so parseLong/parseDouble/parseFloat will work
CodegenParameter defaultValues:
Further work
I verified that all spring generators use classes that require String defaultValues for query params.
These are:
Verification Test
PR checklist
./bin/
(or Windows batch scripts under.\bin\windows
) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the code or mustache templates for a language ({LANG}
) (e.g. php, ruby, python, etc).master
,4.3.x
,5.0.x
. Default:master
.Java Technical Committee:
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)