[JAVA][FEIGN] Implement unit tests for java-feign client #8484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement tests Migrate to junit 5
Default feign client does not support PATCH verb
borsch
reviewed
Jan 20, 2021
modules/openapi-generator/src/main/resources/Java/libraries/feign/api_test.mustache
Show resolved
Hide resolved
wing328
reviewed
Jan 21, 2021
...client/petstore/java/feign/src/test/java/org/openapitools/client/api/AnotherFakeApiTest.java
Outdated
Show resolved
Hide resolved
wing328
reviewed
Jan 22, 2021
modules/openapi-generator/src/main/resources/Java/libraries/feign/api_test.mustache
Outdated
Show resolved
Hide resolved
|
CircleCI failure not related to this change. |
|
Notice that the indentation has changed from 4-space to 2-space in the test files. Users are advised to use a code formatter (e.g. prettier.io) to automatically format the auto-generated code to make the code conforms to code style set by the users. |
This was referenced Jan 28, 2021
wing328
changed the title
martin-mfg
added a commit
to martin-mfg/openapi-generator
that referenced
this pull request
Sep 22, 2023
…s/client/petstore/java/feign/feign10x/ files, generate samples commons-io dependency was introduced in OpenAPITools#8484, but I don't see why it would be needed now or back then.
wing328
pushed a commit
that referenced
this pull request
Oct 9, 2023
* upgrade spring-boot-starter-parent * upgrade springdoc and swagger-ui * upgrade v3 swagger-annotations * generate samples * upgrade jackson * fix spring cloud, remove temp comment Putting "8" instead of "1.8" should be ok, because Spring Boot 3 requires Java 17 anyway, so it should be able to understand that 8 is the same as 1.8. * generate samples * upgrade JUnit 5, remove commons-io dependency, remove outdated samples/client/petstore/java/feign/feign10x/ files, generate samples commons-io dependency was introduced in #8484, but I don't see why it would be needed now or back then. * update gson, generate samples * update logback * update feign * update scribejava * generate samples * update httpmime * okhttp-gson: update commons-lang & okhttp & junit-platform, remove mockito; generate samples It seems Mockito is not used at all there. * okhttp-gson: remove unnecessary sample files, generate sample files * upgrade google-api-client & jersey-common, restore ClientTest, generate samples * misc. upgrades in jersey2 and jersey3 jersey 3.1.3 is available already, but IntelliJ reports security problems in 3.1.3 and 3.1.2, so I used 3.1.1 instead. * align some gradle&sbt files with poms, generate samples * whitespace fix
AlanCitrix
pushed a commit
to AlanCitrix/openapi-generator
that referenced
this pull request
Oct 26, 2023
* upgrade spring-boot-starter-parent * upgrade springdoc and swagger-ui * upgrade v3 swagger-annotations * generate samples * upgrade jackson * fix spring cloud, remove temp comment Putting "8" instead of "1.8" should be ok, because Spring Boot 3 requires Java 17 anyway, so it should be able to understand that 8 is the same as 1.8. * generate samples * upgrade JUnit 5, remove commons-io dependency, remove outdated samples/client/petstore/java/feign/feign10x/ files, generate samples commons-io dependency was introduced in OpenAPITools#8484, but I don't see why it would be needed now or back then. * update gson, generate samples * update logback * update feign * update scribejava * generate samples * update httpmime * okhttp-gson: update commons-lang & okhttp & junit-platform, remove mockito; generate samples It seems Mockito is not used at all there. * okhttp-gson: remove unnecessary sample files, generate sample files * upgrade google-api-client & jersey-common, restore ClientTest, generate samples * misc. upgrades in jersey2 and jersey3 jersey 3.1.3 is available already, but IntelliJ reports security problems in 3.1.3 and 3.1.2, so I used 3.1.1 instead. * align some gradle&sbt files with poms, generate samples * whitespace fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
This PR includes the following changes
cc:
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01)
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master,5.1.x,6.0.x