Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS] disable lint in index file #9675

Merged
merged 3 commits into from
Aug 6, 2021

Conversation

ota42y
Copy link
Contributor

@ota42y ota42y commented Jun 4, 2021

We disable lint in typescript-fetch in this PR
#4110

But we doesn't disable index.ts files so we'll get error with no-cycle rule.

So we need disable all generated file.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)

We disable lint in typescript-fetch in this PR
OpenAPITools#4110

But we doesn't disable index.ts files so we'll get error with [no-cycle](https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-cycle.md) rule.

- index.ts [import all classFiles](https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/resources/typescript-fetch/models.index.mustache#L4) to exporting
- When model use another models (i.e. article model have user model as author), model import another model [using index.ts](https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/resources/typescript-fetch/modelGeneric.mustache#L10)

So we need disable all generated file.
@ota42y ota42y force-pushed the feature/ignore_lint_ts_fetch branch from cf8d270 to dfce063 Compare June 4, 2021 13:32
@ota42y
Copy link
Contributor Author

ota42y commented Jun 5, 2021

travis-ci failed by docker pull error so please rebuild (I can't rebuild perhaps owner and team member only)
https://travis-ci.org/github/OpenAPITools/openapi-generator/builds/773497653

appveyor failed but master branch is failed too, so this PR is no problem

@ota42y
Copy link
Contributor Author

ota42y commented Jun 5, 2021

I think we can merge this to 5.1.x or 6.0.x because it seems that the cause was just forgetting to add it, so it is close to a bug and many users can benefit quickly.
(If you agree that you should merge it with something other than master, recreate it.)

@ota42y ota42y marked this pull request as ready for review June 5, 2021 02:19
@TiFu
Copy link
Contributor

TiFu commented Jun 12, 2021

travis-ci failed by docker pull error so please rebuild (I can't rebuild perhaps owner and team member only)

You can just close and re-open the PR to trigger the CI again ;-) Will re-open the PR in a second.

I think we can merge this to 5.1.x or 6.0.x because it seems that the cause was just forgetting to add it, so it is close to a bug and many users can benefit quickly.
(If you agree that you should merge it with something other than master, recreate it.)

@wing328 What do you think?

@TiFu TiFu closed this Jun 12, 2021
@TiFu TiFu reopened this Jun 12, 2021
@macjohnny macjohnny merged commit e2ff39d into OpenAPITools:master Aug 6, 2021
@wing328 wing328 added this to the 5.2.1 milestone Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants