add scripts/downloads.py #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KIRA009 any idea why the number reported by this script (151) does not match the sum on the landing page (214)? 
|
|
Think this is the same thing that we found in the website implementation. The releases contain files other than the two apps, so we have to filter them out - see https://github.com/OpenAdaptAI/OpenAdapt.web/blob/main/utils/githubStats.js |
|
@KIRA009 I don't think that's it. I've updated the PR description to include the asset names, it only selects the relevant assets by default. In addition, the number produced by this script is lower than the number on the website, which means it's impossible for it to be over counting compared to the website. |
|
Ah, it looks like you are only getting results from 1 page. There are three pages of releases in the api - https://api.github.com/repos/OpenAdaptAI/OpenAdapt/releases?page=3. In the website implementation, I increment the page number after every response until I get a response with no releases |
|
With pagination: 
Compare: |
|
156+82-175 = 63 |
|
250 - 187 = 63 |
KIRA009
suggested changes
Jun 13, 2024
|
Thank you @KIRA009 ! 🙏 
|
R-ohit-B-isht
pushed a commit
to R-ohit-B-isht/OpenAdapt
that referenced
this pull request
Jun 21, 2024
* add scripts/downloads.py * add total cumulative downloads to title * add module docstring * pagination * add datetime * accumulate by release_date * black/flake8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a script at
scripts/downloads.pythat produces the following:Previously:
c.f.