Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posthog event logging updates #772

Merged
merged 5 commits into from
Jun 19, 2024

Conversation

KIRA009
Copy link
Contributor

@KIRA009 KIRA009 commented Jun 18, 2024

What kind of change does this PR introduce?
This PR adds a version number of the openadapt build to posthog events, so its easier to debug the source of erroneous events. It also adds a fix so that submenus in the tray, that have the name of the recording are not reported, rather the underlying action is reported

Summary
Address #768

Checklist

  • My code follows the style guidelines of OpenAdapt
  • I have performed a self-review of my code
  • If applicable, I have added tests to prove my fix is functional/effective
  • I have linted my code locally prior to submission
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. README.md, requirements.txt)
  • New and existing unit tests pass locally with my changes

How can your code be run and tested?
In utils.py, comment out the lines that disable posthog in the get_posthog_instance function. I have added a property to psothog events that will differentiate dev events from events coming from the app, so this can be used when we need to test without polluting the events charts. Play around with the tray (also the submenus) and check that the events are logged correctly

@KIRA009 KIRA009 mentioned this pull request Jun 18, 2024
@abrichr
Copy link
Member

abrichr commented Jun 18, 2024

@KIRA009 can you please fix merge conflicts? I believe we should pass in recording to get_perf_stats

Copy link
Member

@abrichr abrichr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@abrichr abrichr merged commit 59c2714 into OpenAdaptAI:main Jun 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants