Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Added the serverlog periodic reclamation function #2828

Closed
wants to merge 4 commits into from

Conversation

XiaoLiang2333
Copy link
Contributor

@XiaoLiang2333 XiaoLiang2333 commented Jul 26, 2024

#2811
Configure the serverlog clear time using the log-retention-time field in pika.conf. Logs that exceed the clear time will be cleared

Summary by CodeRabbit

  • New Features

    • Introduced a log-retention-time configuration for managing server log file retention.
    • Added new Kubernetes Custom Resource Definitions (CRDs) for pika-group, pika-codis-dashboard, pika-codis-fe, pika-codis-proxy, pika-etcd, and pika-exporter, enhancing component version management.
  • Improvements

    • Improved log purging functionality by separating binlog and server log purging processes.
    • Enhanced Helm chart configuration for better topology management and logging capabilities.
  • Bug Fixes

    • Removed deprecated configuration lines to streamline settings and reduce errors.

Copy link

coderabbitai bot commented Jul 26, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The recent updates enhance Pika's log management and configuration features. A new log-retention-time parameter empowers users to specify log file lifespans, while the PikaServer class has been refactored to separate log purging methods for server logs and binlogs. Helm chart configurations have been streamlined to adopt a topology-focused structure, simplifying management. Additionally, new custom resource definitions have been added to improve the management of component versions in Kubernetes.

Changes

File Path Change Summary
conf/pika.conf Added log-retention-time parameter to manage log file retention (default: 7 days).
include/pika_conf.h Introduced int log_retention_time() method and log_retention_time_ member variable for log management.
include/pika_server.h, src/pika_server.cc Refactored AutoPurge() into AutoBinlogPurge() and AutoServerlogPurge() for targeted log handling.
tools/kubeblocks_helm/.../cluster.yaml Updated to use topology: replication-codis and removed legacy definitions for clarity.
tools/kubeblocks_helm/pika/templates/... Introduced new ComponentVersion files for pika-group, pika-codis-dashboard, pika-codis-fe, etc.
tools/kubeblocks_helm/pika/values.yaml Removed clusterVersionOverride to simplify configuration.
tools/kubeblocks_helm/pika/.helmignore Changed comment from "Common backup files" to "Common files".
tools/kubeblocks_helm/pika/script/admin.sh Updated GROUP_ID assignment to derive from KB_POD_NAME instead of KB_CLUSTER_COMP_NAME.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant PikaServer
    participant LogManager

    User->>PikaServer: Configure log retention
    PikaServer->>LogManager: Set log-retention-time
    LogManager-->>PikaServer: Log retention time set successfully
    PikaServer->>LogManager: Execute AutoServerlogPurge()
    LogManager-->>PikaServer: Purging outdated logs
    PikaServer-->>User: Logs managed successfully
Loading

🐇✨ In the meadow where we hop and play,
New logs are kept, old ones say "Away!"
With tidy paths and a sprightly cheer,
Pika's changes bring us joy, oh dear!
So gather 'round, let's all rejoice,
For logs are clean, and we have a voice! 🌼✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the ✏️ Feature New feature or request label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant