Move hamcrest dependency to the parent, upgrade it to 2.2 #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
velo
approved these changes
Aug 3, 2021
There was a problem hiding this comment.
Outstanding cleanup, having 2 versions was so amateur 🤦♂️
Next challenge is to consolidate all into a single assertion library, right now, we have assertJ, hamcrest and vanilla junit =)
Not to mention junit5
Any, I'm just mumbling, all above just wishes for the future, thanks for the great job
Is it possible to use a single dependency? Or need both hamcrest and hamcrest-library? Any chance that one pulls the other automatically?
It is a good question: |
velo
approved these changes
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes was discussed in #1452
#1452 (comment)
#1452 (comment)