Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed dangling javadoc comment warning by applying new mapping #1568

Merged
merged 3 commits into from
Jan 17, 2022
Merged

Fixed dangling javadoc comment warning by applying new mapping #1568

merged 3 commits into from
Jan 17, 2022

Conversation

Hakky54
Copy link
Contributor

@Hakky54 Hakky54 commented Jan 17, 2022

This is a new PR based on the feedback from this PR: #1557

@Hakky54
Copy link
Contributor Author

Hakky54 commented Jan 17, 2022

Hi @velo I recreated the pull request with the pom adjustment like you mentioned here: #1557 (comment)

velo
velo approved these changes Jan 17, 2022
View reviewed changes
Copy link
Member

@velo velo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apply license formatter, seems go to go

@Hakky54
Copy link
Contributor Author

Hakky54 commented Jan 17, 2022

Awesome, thank you very much! Any idea why the build is failing. I can't see the logs

@velo
Copy link
Member

velo commented Jan 17, 2022

Awesome, thank you very much! Any idea why the build is failing. I can't see the logs

fixed

@velo velo merged commit f71849d into OpenFeign:master Jan 17, 2022
@Hakky54 Hakky54 deleted the fix-copyright-header branch January 17, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@velo velo velo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hakky54 @velo