Update the guide to use JakartaEE 9 with javax-annotations-api #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hutchig
suggested changes
Jan 16, 2023
There was a problem hiding this comment.
Need to check use of tomcat: See OpenLiberty/open-liberty#23922
gkwan-ibm
changed the title
ReeceNana
approved these changes
Jan 26, 2023
ReeceNana
approved these changes
Jan 26, 2023
hutchig
approved these changes
Jan 27, 2023
|
One more, trivial, comment. Also, although personally as an author I prefer daily etc commits for off-laptop check-in safety, I think we are encouraged to 'squash' commits into a few meaningful 'chunks' for review (and 1 per post review issue/reviewer) rather than retain the whole list of the operational-chunked commits in the gitlog of the main branch. Not important but worth becoming comfortable with squashing. |
gkwan-ibm
added a commit
that referenced
this pull request
Jan 27, 2023
Merge staging to prod - Update the guide to use JakartaEE 9 with javax-annotations-api (#43)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
address issue #21
Update the guide to use JakartaEE 9 with
tomcat-annotations-apijavax-annotations-api