Restored parent::save() on a few classes (fixing PHPStan) ref #3988 (#…

…4021)
OpenMage · May 30, 2024 · ed34c76 · ed34c76
1 parent 97a8fa0
commit ed34c76
Show file tree

Hide file tree

Showing 11 changed files with 4,429 additions and 4,378 deletions.
diff --git a/.phpstorm.meta.php/magento_helpers.meta.php b/.phpstorm.meta.php/magento_helpers.meta.php
@@ -17,8 +17,8 @@
             'adminhtml/dashboard_abstract' => \Mage_Adminhtml_Helper_Dashboard_Abstract::class,
             'adminhtml/dashboard_data' => \Mage_Adminhtml_Helper_Dashboard_Data::class,
             'adminhtml/dashboard_order' => \Mage_Adminhtml_Helper_Dashboard_Order::class,
-            'adminhtml' => \Mage_Adminhtml_Helper_Data::class,
             'adminhtml/data' => \Mage_Adminhtml_Helper_Data::class,
+            'adminhtml' => \Mage_Adminhtml_Helper_Data::class,
             'adminhtml/help_mapping' => \Mage_Adminhtml_Helper_Help_Mapping::class,
             'adminhtml/js' => \Mage_Adminhtml_Helper_Js::class,
             'adminhtml/media_js' => \Mage_Adminhtml_Helper_Media_Js::class,
@@ -29,25 +29,25 @@
             'api' => \Mage_Api_Helper_Data::class,
             'api/data' => \Mage_Api_Helper_Data::class,
             'authorizenet/admin' => \Mage_Authorizenet_Helper_Admin::class,
-            'authorizenet' => \Mage_Authorizenet_Helper_Data::class,
             'authorizenet/data' => \Mage_Authorizenet_Helper_Data::class,
+            'authorizenet' => \Mage_Authorizenet_Helper_Data::class,
             'bundle/catalog_product_configuration' => \Mage_Bundle_Helper_Catalog_Product_Configuration::class,
-            'bundle' => \Mage_Bundle_Helper_Data::class,
             'bundle/data' => \Mage_Bundle_Helper_Data::class,
+            'bundle' => \Mage_Bundle_Helper_Data::class,
             'captcha' => \Mage_Captcha_Helper_Data::class,
             'captcha/data' => \Mage_Captcha_Helper_Data::class,
             'cataloginventory' => \Mage_CatalogInventory_Helper_Data::class,
             'cataloginventory/data' => \Mage_CatalogInventory_Helper_Data::class,
             'cataloginventory/minsaleqty' => \Mage_CatalogInventory_Helper_Minsaleqty::class,
             'catalogrule' => \Mage_CatalogRule_Helper_Data::class,
             'catalogrule/data' => \Mage_CatalogRule_Helper_Data::class,
-            'catalogsearch' => \Mage_CatalogSearch_Helper_Data::class,
             'catalogsearch/data' => \Mage_CatalogSearch_Helper_Data::class,
+            'catalogsearch' => \Mage_CatalogSearch_Helper_Data::class,
             'catalog/category' => \Mage_Catalog_Helper_Category::class,
             'catalog/category_flat' => \Mage_Catalog_Helper_Category_Flat::class,
             'catalog/category_url_rewrite' => \Mage_Catalog_Helper_Category_Url_Rewrite::class,
-            'catalog' => \Mage_Catalog_Helper_Data::class,
             'catalog/data' => \Mage_Catalog_Helper_Data::class,
+            'catalog' => \Mage_Catalog_Helper_Data::class,
             'catalog/flat_abstract' => \Mage_Catalog_Helper_Flat_Abstract::class,
             'catalog/image' => \Mage_Catalog_Helper_Image::class,
             'catalog/map' => \Mage_Catalog_Helper_Map::class,
@@ -61,8 +61,8 @@
             'catalog/product_url' => \Mage_Catalog_Helper_Product_Url::class,
             'catalog/product_url_rewrite' => \Mage_Catalog_Helper_Product_Url_Rewrite::class,
             'catalog/product_view' => \Mage_Catalog_Helper_Product_View::class,
-            'centinel' => \Mage_Centinel_Helper_Data::class,
             'centinel/data' => \Mage_Centinel_Helper_Data::class,
+            'centinel' => \Mage_Centinel_Helper_Data::class,
             'checkout/cart' => \Mage_Checkout_Helper_Cart::class,
             'checkout' => \Mage_Checkout_Helper_Data::class,
             'checkout/data' => \Mage_Checkout_Helper_Data::class,
@@ -81,8 +81,8 @@
             'core/abstract' => \Mage_Core_Helper_Abstract::class,
             'core/array' => \Mage_Core_Helper_Array::class,
             'core/cookie' => \Mage_Core_Helper_Cookie::class,
-            'core' => \Mage_Core_Helper_Data::class,
             'core/data' => \Mage_Core_Helper_Data::class,
+            'core' => \Mage_Core_Helper_Data::class,
             'core/environmentConfigLoader' => \Mage_Core_Helper_EnvironmentConfigLoader::class,
             'core/file_storage' => \Mage_Core_Helper_File_Storage::class,
             'core/file_storage_database' => \Mage_Core_Helper_File_Storage_Database::class,
@@ -101,8 +101,8 @@
             'customer/address' => \Mage_Customer_Helper_Address::class,
             'customer' => \Mage_Customer_Helper_Data::class,
             'customer/data' => \Mage_Customer_Helper_Data::class,
-            'dataflow' => \Mage_Dataflow_Helper_Data::class,
             'dataflow/data' => \Mage_Dataflow_Helper_Data::class,
+            'dataflow' => \Mage_Dataflow_Helper_Data::class,
             'directory' => \Mage_Directory_Helper_Data::class,
             'directory/data' => \Mage_Directory_Helper_Data::class,
             'directory/url' => \Mage_Directory_Helper_Url::class,
@@ -117,18 +117,18 @@
             'giftmessage/data' => \Mage_GiftMessage_Helper_Data::class,
             'giftmessage/message' => \Mage_GiftMessage_Helper_Message::class,
             'giftmessage/url' => \Mage_GiftMessage_Helper_Url::class,
-            'googleanalytics' => \Mage_GoogleAnalytics_Helper_Data::class,
             'googleanalytics/data' => \Mage_GoogleAnalytics_Helper_Data::class,
-            'importexport' => \Mage_ImportExport_Helper_Data::class,
+            'googleanalytics' => \Mage_GoogleAnalytics_Helper_Data::class,
             'importexport/data' => \Mage_ImportExport_Helper_Data::class,
+            'importexport' => \Mage_ImportExport_Helper_Data::class,
             'index' => \Mage_Index_Helper_Data::class,
             'index/data' => \Mage_Index_Helper_Data::class,
             'install' => \Mage_Install_Helper_Data::class,
             'install/data' => \Mage_Install_Helper_Data::class,
-            'log' => \Mage_Log_Helper_Data::class,
             'log/data' => \Mage_Log_Helper_Data::class,
-            'media' => \Mage_Media_Helper_Data::class,
+            'log' => \Mage_Log_Helper_Data::class,
             'media/data' => \Mage_Media_Helper_Data::class,
+            'media' => \Mage_Media_Helper_Data::class,
             'newsletter' => \Mage_Newsletter_Helper_Data::class,
             'newsletter/data' => \Mage_Newsletter_Helper_Data::class,
             'oauth' => \Mage_Oauth_Helper_Data::class,
@@ -139,19 +139,19 @@
             'page/layout' => \Mage_Page_Helper_Layout::class,
             'payment' => \Mage_Payment_Helper_Data::class,
             'payment/data' => \Mage_Payment_Helper_Data::class,
-            'paypaluk' => \Mage_PaypalUk_Helper_Data::class,
             'paypaluk/data' => \Mage_PaypalUk_Helper_Data::class,
+            'paypaluk' => \Mage_PaypalUk_Helper_Data::class,
             'paypal/checkout' => \Mage_Paypal_Helper_Checkout::class,
-            'paypal' => \Mage_Paypal_Helper_Data::class,
             'paypal/data' => \Mage_Paypal_Helper_Data::class,
+            'paypal' => \Mage_Paypal_Helper_Data::class,
             'paypal/hss' => \Mage_Paypal_Helper_Hss::class,
             'persistent' => \Mage_Persistent_Helper_Data::class,
             'persistent/data' => \Mage_Persistent_Helper_Data::class,
             'persistent/session' => \Mage_Persistent_Helper_Session::class,
-            'productalert' => \Mage_ProductAlert_Helper_Data::class,
             'productalert/data' => \Mage_ProductAlert_Helper_Data::class,
-            'rating' => \Mage_Rating_Helper_Data::class,
+            'productalert' => \Mage_ProductAlert_Helper_Data::class,
             'rating/data' => \Mage_Rating_Helper_Data::class,
+            'rating' => \Mage_Rating_Helper_Data::class,
             'reports' => \Mage_Reports_Helper_Data::class,
             'reports/data' => \Mage_Reports_Helper_Data::class,
             'review' => \Mage_Review_Helper_Data::class,
@@ -165,22 +165,22 @@
             'salesrule/coupon' => \Mage_SalesRule_Helper_Coupon::class,
             'salesrule' => \Mage_SalesRule_Helper_Data::class,
             'salesrule/data' => \Mage_SalesRule_Helper_Data::class,
-            'sales' => \Mage_Sales_Helper_Data::class,
             'sales/data' => \Mage_Sales_Helper_Data::class,
+            'sales' => \Mage_Sales_Helper_Data::class,
             'sales/guest' => \Mage_Sales_Helper_Guest::class,
             'sales/reorder' => \Mage_Sales_Helper_Reorder::class,
-            'sendfriend' => \Mage_Sendfriend_Helper_Data::class,
             'sendfriend/data' => \Mage_Sendfriend_Helper_Data::class,
+            'sendfriend' => \Mage_Sendfriend_Helper_Data::class,
             'shipping' => \Mage_Shipping_Helper_Data::class,
             'shipping/data' => \Mage_Shipping_Helper_Data::class,
             'sitemap' => \Mage_Sitemap_Helper_Data::class,
             'sitemap/data' => \Mage_Sitemap_Helper_Data::class,
             'tag' => \Mage_Tag_Helper_Data::class,
             'tag/data' => \Mage_Tag_Helper_Data::class,
-            'tax' => \Mage_Tax_Helper_Data::class,
             'tax/data' => \Mage_Tax_Helper_Data::class,
-            'uploader' => \Mage_Uploader_Helper_Data::class,
+            'tax' => \Mage_Tax_Helper_Data::class,
             'uploader/data' => \Mage_Uploader_Helper_Data::class,
+            'uploader' => \Mage_Uploader_Helper_Data::class,
             'uploader/file' => \Mage_Uploader_Helper_File::class,
             'usa' => \Mage_Usa_Helper_Data::class,
             'usa/data' => \Mage_Usa_Helper_Data::class,