Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check if SUPEE-389 needs to be applied (Every time the catalog URL is rendexed, a new custom rewrite is created) #26

Closed
tmotyl opened this issue Jun 30, 2015 · 4 comments
Closed

check if SUPEE-389 needs to be applied (Every time the catalog URL is rendexed, a new custom rewrite is created) #26

tmotyl opened this issue Jun 30, 2015 · 4 comments
Labels
bug SUPEE Relates to security patches url rewrites

Comments

@tmotyl
Copy link
Contributor

tmotyl commented Jun 30, 2015

SUPEE-389: Every time the catalog URL is rendexed, a new custom rewrite is created
https://gist.github.com/piotrekkaminski/c348538ca91ba35773be
@drobinson
Copy link
Collaborator

Doesn't look like this has been included in the core yet, do you want to apply it or wait and see if we get it with a new version?

@seansan
Copy link
Contributor

seansan commented Oct 11, 2016

Would Wait now if it is only 1 week. But I know many sites where this is a problem. SO if not included I would suggest to add it immediately

@tomekjordan tomekjordan mentioned this issue Feb 22, 2017
Closed
@drobinson
Copy link
Collaborator

It looks like this was built into the original getUnusedPath method - circa v 1.13.1

@sprankhub
Copy link
Contributor

@drobinson could you share details? In my experience, Magento 1.9.3.4 still creates more and more rewrites with each reindex.

@sreichel sreichel added bug patch SUPEE Relates to security patches url rewrites labels Jun 27, 2020
sreichel added a commit that referenced this issue Nov 29, 2022
@sreichel @kiatng
Add php-cs-fixer & PHPCompatibility check to workflow (#2744)
7fe65ad 
* PHP-CS-Fixer fixes

Signed-off-by: Sven Reichel <github-sr@hotmail.com>

* Updated workflow

Signed-off-by: Sven Reichel <github-sr@hotmail.com>

* Added php-cs-fixer workflow

Signed-off-by: Sven Reichel <github-sr@hotmail.com>

* Added PHPCompatibility check

* PHPCompatibility check can fail

* Fixes: Node.js 12 actions are deprecated

* Fixes: PSR12.ControlStructures.ControlStructureSpacing.LineIndent

* Fixes: PSR12.ControlStructures.ControlStructureSpacing.CloseParenthesisLine

* Dond check CM_Redis every time

* Add .php-cs-fixer.cache to .gitignore

* Fixes class name (wrong place ... i know)

* Minor fixes

* Combined workflows

* Added app/Mage.php and files from root to rulesets

* Remove unused phpstan_experimental_level.neon

* Updated phpstan.neon (for upcoming commits)

* Set PhpStan level to 5 (from 3)

* Update phpstan to v1.9.2

* Updated phpstan-baseline.neon

* Updated phpstan-baseline.neon

* Update app/code/core/Mage/Tag/Model/Resource/Tag.php

Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>

* Update lib/Varien/Db/Adapter/Pdo/Mysql.php

Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>

* Set workflow include paths (skip other files)

* Updated labeler.yml

* Removed travis label

* Improved workflow (#26)

* Fixed grep modifier to get correct count

* Updated ECG sniff baseline

* Added Mage_Centinal to PhpStan checks

* Added Mage_PaypalUk to PhpStan checks

* Update app/code/core/Mage/Paypal/Model/Config.php

Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>

Signed-off-by: Sven Reichel <github-sr@hotmail.com>
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
@matteotestoni matteotestoni mentioned this issue Mar 16, 2023
Closed
@andyt andyt mentioned this issue Apr 24, 2023
Closed
justinbeaty pushed a commit to justinbeaty/magento-lts that referenced this issue Sep 28, 2024
@tmewes
Replaced CRLF with LF line separators (OpenMage#26)
7e93ad1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug SUPEE Relates to security patches url rewrites
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@drobinson @tmotyl @seansan @sprankhub @sreichel @ADDISON74