Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New feature: added partial postcode match to table rate shipping #1504

Merged
merged 5 commits into from
Feb 21, 2024
Merged

New feature: added partial postcode match to table rate shipping #1504

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
306f841
Added partial postcode match to table rate shipping
AlterWeb Mar 17, 2021
23dc018
Merge branch 'main' into feature/shippingtablerates
fballiano May 6, 2023
820723f
Merge branch 'main' into feature/shippingtablerates
fballiano Feb 21, 2024
4df7142
phpcs
fballiano Feb 21, 2024
415d206
this line was missing
fballiano Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 26 additions & 12 deletions app/code/core/Mage/Shipping/Model/Resource/Carrier/Tablerate.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,24 +108,38 @@ public function getRate(Mage_Shipping_Model_Rate_Request $request)
$select = $adapter->select()
->from($this->getMainTable())
->where('website_id = :website_id')
->order(['dest_country_id DESC', 'dest_region_id DESC', 'dest_zip DESC', 'condition_value DESC'])
->order(['dest_country_id DESC', 'dest_region_id DESC', 'LENGTH(dest_zip) DESC', 'dest_zip DESC', 'condition_value DESC'])
->limit(1);

// Render destination condition
$orWhere = '(' . implode(') OR (', [
$conditions = [
"dest_country_id = :country_id AND dest_region_id = :region_id AND dest_zip = :postcode",
"dest_country_id = :country_id AND dest_region_id = :region_id AND dest_zip = ''",
"dest_country_id = :country_id AND dest_region_id = '0' AND dest_zip = :postcode",
"dest_country_id = '0' AND dest_region_id = :region_id AND dest_zip = :postcode",
"dest_country_id = '0' AND dest_region_id = '0' AND dest_zip = :postcode",
"dest_country_id = :country_id AND dest_region_id = '0' AND dest_zip = ''"
];

// Handle asterix in dest_zip field
"dest_country_id = :country_id AND dest_region_id = :region_id AND dest_zip = '*'",
"dest_country_id = :country_id AND dest_region_id = 0 AND dest_zip = '*'",
"dest_country_id = '0' AND dest_region_id = :region_id AND dest_zip = '*'",
"dest_country_id = '0' AND dest_region_id = 0 AND dest_zip = '*'",
// Handle asterix in dest_zip field
$conditions[] = "dest_country_id = :country_id AND dest_region_id = :region_id AND dest_zip = '*'";
$conditions[] = "dest_country_id = :country_id AND dest_region_id = '0' AND dest_zip = '*'";
$conditions[] = "dest_country_id = '0' AND dest_region_id = :region_id AND dest_zip = '*'";
$conditions[] = "dest_country_id = '0' AND dest_region_id = '0' AND dest_zip = '*'";

$i = 0;
$postcode = $request->getDestPostcode();
while (strlen($postcode) > 1) {
$i++;
$postcode = substr($postcode, 0, -1);
$bind[':wildcard_postcode_' . $i] = "{$postcode}*";
$conditions[] = "dest_country_id = :country_id AND dest_region_id = :region_id AND dest_zip = :wildcard_postcode_{$i}";
$conditions[] = "dest_country_id = :country_id AND dest_region_id = '0' AND dest_zip = :wildcard_postcode_{$i}";
$conditions[] = "dest_country_id = '0' AND dest_region_id = :region_id AND dest_zip = :wildcard_postcode_{$i}";
$conditions[] = "dest_country_id = '0' AND dest_region_id = '0' AND dest_zip = :wildcard_postcode_{$i}";
}

"dest_country_id = :country_id AND dest_region_id = 0 AND dest_zip = ''",
"dest_country_id = :country_id AND dest_region_id = 0 AND dest_zip = :postcode",
"dest_country_id = :country_id AND dest_region_id = 0 AND dest_zip = '*'",
]) . ')';
// Render destination condition
$orWhere = '(' . implode(') OR (', $conditions) . ')';
$select->where($orWhere);

// Render condition by condition name
Expand Down
Loading