Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/20.x #1037 Remove theme default/modern & default/iphone #1611

Closed
wants to merge 2 commits into from
Closed

Feature/20.x #1037 Remove theme default/modern & default/iphone #1611

wants to merge 2 commits into from

Conversation

kkrieger85
Copy link
Contributor

Description (*)

Remove default/modern and default/iphone theme (app/design/frontend/% and skin/frontend/% )

Fixed Issues (if relevant)

Fixes #1037

Kevin Krieger added 2 commits May 12, 2021 13:38
refactor(template)!: remove default/modern layout & skin
c80702b 
BREAKING CHANGE: theme will be removed and can not used as parent theme
refactor(template)!: remove default/iphone layout & skin
f759748 
BREAKING CHANGE: theme will be removed and can not used as parent theme
@github-actions github-actions bot added Component: Bundle Relates to Mage_Bundle Component: Catalog Relates to Mage_Catalog Component: CatalogSearch Relates to Mage_CatalogSearch Component: Checkout Relates to Mage_Checkout Component: Cms Relates to Mage_Cms Component: Contacts Relates to Mage_Contacts Component: Customer Relates to Mage_Customer Component: Downloadable Relates to Mage_Downloadable Component: Newsletter Relates to Mage_Newsletter Component: Page Relates to Mage_Page Component: Payment Relates to Mage_Payment Component: PayPal Relates to Mage_Paypal Component: Persistant Relates to Mage_Persistant Component: Review Relates to Mage_Review Component: Rss Relates to Mage_Rss Component: Sales Relates to Mage_Sales Component: Sendfriend Relates to Mage_Sendfriend Component: Shipping Relates to Mage_Shipping Component: Tag Relates to Mage_Tag Component: Tax Relates to Mage_Tax Component: Wishlist Relates to Mage_Wishlist Template : default Relates to base template XML Layout labels May 12, 2021
@kkrieger85 kkrieger85 closed this May 12, 2021
@lgtm-com
Copy link

lgtm-com bot commented May 12, 2021

This pull request fixes 17 alerts when merging f759748 into 46ebf30 - view on LGTM.com

fixed alerts:

  • 11 for Unused variable, import, function or class
  • 5 for Missing variable declaration
  • 1 for Expression has no effect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: Bundle Relates to Mage_Bundle Component: Catalog Relates to Mage_Catalog Component: CatalogSearch Relates to Mage_CatalogSearch Component: Checkout Relates to Mage_Checkout Component: Cms Relates to Mage_Cms Component: Contacts Relates to Mage_Contacts Component: Customer Relates to Mage_Customer Component: Downloadable Relates to Mage_Downloadable Component: Newsletter Relates to Mage_Newsletter Component: Page Relates to Mage_Page Component: Payment Relates to Mage_Payment Component: PayPal Relates to Mage_Paypal Component: Persistant Relates to Mage_Persistant Component: Review Relates to Mage_Review Component: Rss Relates to Mage_Rss Component: Sales Relates to Mage_Sales Component: Sendfriend Relates to Mage_Sendfriend Component: Shipping Relates to Mage_Shipping Component: Tag Relates to Mage_Tag Component: Tax Relates to Mage_Tax Component: Wishlist Relates to Mage_Wishlist Template : default Relates to base template XML Layout
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kkrieger85