Remove deprecated utf8_encode() for PHP 8.2 #2404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sdfendor
approved these changes
Aug 11, 2022
ADDISON74
approved these changes
Aug 11, 2022
Flyingmana
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.2 deprecated
utf8_encode()andutf8_decode(): https://wiki.php.net/rfc/remove_utf8_decode_and_utf8_encodeThis PR switched
utf8_encode()calls tomb_convert_encoding()(it's the suggested method in the RFC above).Notes:
lib/Zendor in the modules touched by Move phpseclib, mcrypt_compat, net_idna2, Cm_RedisSession and Cm_Cache_Backend_Redis to composer #2138utf8_decode()(also deprecated) are inlib/I didn't touch them either