Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add autocomplete attribute to known password fields. #2700

Merged
merged 2 commits into from
Dec 30, 2022
Merged

Add autocomplete attribute to known password fields. #2700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1afed8e
Add autocomplete attribute to known password fields.
rfeese Nov 9, 2022
a61df5d
Add myself to contributors.
rfeese Nov 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .all-contributorsrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1351,6 +1351,15 @@
"contributions": [
"code"
]
},
{
"login": "rfeese",
"name": "Roger Feese",
"avatar_url": "https://avatars.githubusercontent.com/u/7074181?v=4",
"profile": "https://github.com/rfeese",
"contributions": [
"code"
]
}
],
"contributorsPerLine": 7
Expand Down
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,6 +427,7 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d
<tr>
<td align="center"><a href="https://github.com/eneiasramos"><img src="https://avatars.githubusercontent.com/u/2862728?v=4" loading="lazy" width="100" alt=""/><br /><sub><b>Enéias Ramos de Melo</b></sub></a></td>
<td align="center"><a href="https://github.com/discountscott"><img src="https://avatars.githubusercontent.com/u/5454596?v=4" loading="lazy" width="100" alt=""/><br /><sub><b>Scott Moore</b></sub></a></td>
<td align="center"><a href="https://github.com/rfeese"><img src="https://avatars.githubusercontent.com/u/7074181?v=4" loading="lazy" width="100" alt=""/><br /><sub><b>Roger Feese</b></sub></a></td>
</tr>
</table>

Expand Down
5 changes: 3 additions & 2 deletions app/design/frontend/base/default/template/checkout/onepage/billing.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,8 @@
name="billing[customer_password]"
id="billing:customer_password"
title="<?php echo Mage::helper('core')->quoteEscape($this->__('Password')) ?>"
class="input-text required-entry validate-password min-pass-length-<?php echo $minPasswordLength ?>" />
class="input-text required-entry validate-password min-pass-length-<?php echo $minPasswordLength ?>"
autocomplete="off" />
<p class="form-instructions">
<?php echo Mage::helper('customer')->__('The minimum password length is %s', $minPasswordLength) ?>
</p>
Expand All @@ -168,7 +169,7 @@
<div class="field">
<label for="billing:confirm_password" class="required"><em>*</em><?php echo $this->__('Confirm Password') ?></label>
<div class="input-box">
<input type="password" name="billing[confirm_password]" title="<?php echo Mage::helper('core')->quoteEscape($this->__('Confirm Password')) ?>" id="billing:confirm_password" class="input-text required-entry validate-cpassword" />
<input type="password" name="billing[confirm_password]" title="<?php echo Mage::helper('core')->quoteEscape($this->__('Confirm Password')) ?>" id="billing:confirm_password" class="input-text required-entry validate-cpassword" autocomplete="off" />
</div>
</div>
</li>
Expand Down
2 changes: 1 addition & 1 deletion app/design/frontend/base/default/template/checkout/onepage/login.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
<li>
<label for="login-password" class="required"><em>*</em><?php echo $this->__('Password') ?></label>
<div class="input-box">
<input type="password" class="input-text required-entry" id="login-password" name="login[password]" />
<input type="password" class="input-text required-entry" id="login-password" name="login[password]" autocomplete="off" />
</div>
</li>
<?php echo $this->getChildHtml('form.additional.info'); ?>
Expand Down
7 changes: 4 additions & 3 deletions app/design/frontend/base/default/template/customer/form/changepassword.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
<li>
<label for="current_password" class="required"><em>*</em><?php echo $this->__('Current Password') ?></label>
<div class="input-box">
<input type="password" title="<?php echo Mage::helper('core')->quoteEscape($this->__('Current Password')) ?>" class="input-text required-entry" name="current_password" id="current_password" />
<input type="password" title="<?php echo Mage::helper('core')->quoteEscape($this->__('Current Password')) ?>" class="input-text required-entry" name="current_password" id="current_password" autocomplete="off" />
</div>
</li>
<li class="fields">
Expand All @@ -41,7 +41,8 @@
title="<?php echo Mage::helper('core')->quoteEscape($this->__('New Password')) ?>"
class="input-text required-entry validate-password min-pass-length-<?php echo $minPasswordLength ?>"
name="password"
id="password" />
id="password"
autocomplete="new-password" />
<p class="form-instructions">
<?php echo Mage::helper('customer')->__('The minimum password length is %s', $minPasswordLength) ?>
</p>
Expand All @@ -50,7 +51,7 @@
<div class="field">
<label for="confirmation" class="required"><em>*</em><?php echo $this->__('Confirm New Password') ?></label>
<div class="input-box">
<input type="password" title="<?php echo Mage::helper('core')->quoteEscape($this->__('Confirm New Password')) ?>" class="input-text required-entry validate-cpassword" name="confirmation" id="confirmation" />
<input type="password" title="<?php echo Mage::helper('core')->quoteEscape($this->__('Confirm New Password')) ?>" class="input-text required-entry validate-cpassword" name="confirmation" id="confirmation" autocomplete="new-password" />
</div>
</div>
</li>
Expand Down
7 changes: 4 additions & 3 deletions app/design/frontend/base/default/template/customer/form/edit.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
<div class="input-box">
<!-- This is a dummy hidden field to trick firefox from auto filling the password -->
<input type="text" class="input-text no-display" name="dummy" id="dummy" />
<input type="password" title="<?php echo Mage::helper('core')->quoteEscape($this->__('Current Password')) ?>" class="input-text required-entry" name="current_password" id="current_password" />
<input type="password" title="<?php echo Mage::helper('core')->quoteEscape($this->__('Current Password')) ?>" class="input-text required-entry" name="current_password" id="current_password" autocomplete="off" />
</div>
</li>
<li class="control">
Expand All @@ -74,7 +74,8 @@
title="<?php echo Mage::helper('core')->quoteEscape($this->__('New Password')) ?>"
class="input-text required-entry validate-password min-pass-length-<?php echo $minPasswordLength ?>"
name="password"
id="password" />
id="password"
autocomplete="new-password" />
<p class="form-instructions">
<?php echo $this->__('The minimum password length is %s', $minPasswordLength) ?>
</p>
Expand All @@ -83,7 +84,7 @@
<div class="field">
<label for="confirmation" class="required"><em>*</em><?php echo $this->__('Confirm New Password') ?></label>
<div class="input-box">
<input type="password" title="<?php echo Mage::helper('core')->quoteEscape($this->__('Confirm New Password')) ?>" class="input-text required-entry validate-cpassword" name="confirmation" id="confirmation" />
<input type="password" title="<?php echo Mage::helper('core')->quoteEscape($this->__('Confirm New Password')) ?>" class="input-text required-entry validate-cpassword" name="confirmation" id="confirmation" autocomplete="new-password" />
</div>
</div>
</li>
Expand Down
2 changes: 1 addition & 1 deletion app/design/frontend/base/default/template/customer/form/login.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
<li>
<label for="pass" class="required"><em>*</em><?php echo $this->__('Password') ?></label>
<div class="input-box">
<input type="password" name="login[password]" class="input-text required-entry validate-password min-pass-length-5" id="pass" title="<?php echo Mage::helper('core')->quoteEscape($this->__('Password')) ?>" />
<input type="password" name="login[password]" class="input-text required-entry validate-password min-pass-length-5" id="pass" title="<?php echo Mage::helper('core')->quoteEscape($this->__('Password')) ?>" autocomplete="off" />
</div>
</li>
<?php echo $this->getChildHtml('form.additional.info'); ?>
Expand Down
4 changes: 2 additions & 2 deletions app/design/frontend/base/default/template/customer/form/mini.login.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,11 @@
<?php echo $this->getBlockHtml('formkey') ?>
<div class="block-content">
<label for="mini-login"><?php echo $this->__('Email:') ?></label><input type="text" name="login[username]" id="mini-login" class="input-text" />
<label for="mini-password"><?php echo $this->__('Password:') ?></label><input type="password" name="login[password]" id="mini-password" class="input-text" />
<label for="mini-password"><?php echo $this->__('Password:') ?></label><input type="password" name="login[password]" id="mini-password" class="input-text" autocomplete="off" />
<div class="actions">
<button type="submit" class="button"><span><span><?php echo $this->__('Login') ?></span></span></button>
</div>
</div>
</form>
</div>
<?php endif ?>
<?php endif ?>
5 changes: 3 additions & 2 deletions app/design/frontend/base/default/template/customer/form/register.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,8 @@
name="password"
id="password"
title="<?php echo Mage::helper('core')->quoteEscape($this->__('Password')) ?>"
class="input-text required-entry validate-password min-pass-length-<?php echo $minPasswordLength ?>" />
class="input-text required-entry validate-password min-pass-length-<?php echo $minPasswordLength ?>"
autocomplete="off" />
<p class="form-instructions">
<?php echo $this->__('The minimum password length is %s', $minPasswordLength) ?>
</p>
Expand All @@ -170,7 +171,7 @@
<div class="field">
<label for="confirmation" class="required"><em>*</em><?php echo $this->__('Confirm Password') ?></label>
<div class="input-box">
<input type="password" name="confirmation" title="<?php echo Mage::helper('core')->quoteEscape($this->__('Confirm Password')) ?>" id="confirmation" class="input-text required-entry validate-cpassword" />
<input type="password" name="confirmation" title="<?php echo Mage::helper('core')->quoteEscape($this->__('Confirm Password')) ?>" id="confirmation" class="input-text required-entry validate-cpassword" autocomplete="off" />
</div>
</div>
</li>
Expand Down
5 changes: 3 additions & 2 deletions app/design/frontend/base/default/template/customer/form/resetforgottenpassword.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@
<input type="password"
class="input-text required-entry validate-password min-pass-length-<?php echo $minPasswordLength; ?>"
name="password"
id="password" />
id="password"
autocomplete="off" />
<p class="form-instructions">
<?php echo Mage::helper('customer')->__('The minimum password length is %s', $minPasswordLength); ?>
</p>
Expand All @@ -42,7 +43,7 @@
<div class="field">
<label for="confirmation" class="required"><em>*</em><?php echo $this->__('Confirm New Password'); ?></label>
<div class="input-box">
<input type="password" class="input-text required-entry validate-cpassword" name="confirmation" id="confirmation" />
<input type="password" class="input-text required-entry validate-cpassword" name="confirmation" id="confirmation" autocomplete="off "/>
</div>
</div>
</li>
Expand Down
2 changes: 1 addition & 1 deletion app/design/frontend/base/default/template/oauth/authorize/form/login-simple.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
<em class="required">*</em>&nbsp;<?php echo $this->__('Password') ?>
</label>
<input type="password" id="login" name="login[password]" class="required-entry input-text"
value=""/></div>
value="" autocomplete="off" /></div>
<div class="clear"></div>
<div class="form-buttons">
<button type="submit" class="form-button"
Expand Down
2 changes: 1 addition & 1 deletion app/design/frontend/base/default/template/oauth/authorize/form/login.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ $rejectJs = "document.location.href='{$this->getRejectUrl()}';";
<li>
<label for="pass"><?php echo $this->__('Password') ?></label>
<div class="input-box">
<input type="password" name="login[password]" class="input-text required-entry validate-password min-pass-length-5" id="pass" title="<?php echo $this->__('Password') ?>" />
<input type="password" name="login[password]" class="input-text required-entry validate-password min-pass-length-5" id="pass" title="<?php echo $this->__('Password') ?>" autocomplete="off" />
</div>
</li>
</ul>
Expand Down
5 changes: 3 additions & 2 deletions app/design/frontend/base/default/template/persistent/checkout/onepage/billing.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,8 @@
name="billing[customer_password]"
id="billing:customer_password"
title="<?php echo $this->quoteEscape($this->__('Password')) ?>"
class="input-text required-entry validate-password min-pass-length-<?php echo $minPasswordLength ?>" />
class="input-text required-entry validate-password min-pass-length-<?php echo $minPasswordLength ?>"
autocomplete="off" />
<p class="form-instructions">
<?php echo Mage::helper('customer')->__('The minimum password length is %s', $minPasswordLength) ?>
</p>
Expand All @@ -166,7 +167,7 @@
<div class="field">
<label for="billing:confirm_password" class="required"><em>*</em><?php echo $this->__('Confirm Password') ?></label>
<div class="input-box">
<input type="password" name="billing[confirm_password]" title="<?php echo Mage::helper('core')->quoteEscape($this->__('Confirm Password')) ?>" id="billing:confirm_password" class="input-text required-entry validate-cpassword" />
<input type="password" name="billing[confirm_password]" title="<?php echo Mage::helper('core')->quoteEscape($this->__('Confirm Password')) ?>" id="billing:confirm_password" class="input-text required-entry validate-cpassword" autocomplete="off" />
</div>
</div>
</li>
Expand Down
2 changes: 1 addition & 1 deletion app/design/frontend/base/default/template/persistent/checkout/onepage/login.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
<li>
<label for="login-password" class="required"><em>*</em><?php echo $this->__('Password') ?></label>
<div class="input-box">
<input type="password" class="input-text required-entry" id="login-password" name="login[password]" />
<input type="password" class="input-text required-entry" id="login-password" name="login[password]" autocomplete="off" />
</div>
</li>
<?php echo $this->getChildHtml('form.additional.info'); ?>
Expand Down
2 changes: 1 addition & 1 deletion app/design/frontend/base/default/template/persistent/customer/form/login.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
<li>
<label for="pass" class="required"><em>*</em><?php echo $this->__('Password') ?></label>
<div class="input-box">
<input type="password" name="login[password]" class="input-text required-entry" id="pass" title="<?php echo Mage::helper('core')->quoteEscape($this->__('Password')) ?>" />
<input type="password" name="login[password]" class="input-text required-entry" id="pass" title="<?php echo Mage::helper('core')->quoteEscape($this->__('Password')) ?>" autocomplete="off" />
</div>
</li>
<?php echo $this->getChildHtml('form.additional.info'); ?>
Expand Down
5 changes: 3 additions & 2 deletions app/design/frontend/base/default/template/persistent/customer/form/register.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,8 @@
name="password"
id="password"
title="<?php echo $this->quoteEscape($this->__('Password')) ?>"
class="input-text required-entry validate-password min-pass-length-<?php echo $minPasswordLength ?>" />
class="input-text required-entry validate-password min-pass-length-<?php echo $minPasswordLength ?>"
autocomplete="off" />
<p class="form-instructions">
<?php echo Mage::helper('customer')->__('The minimum password length is %s', $minPasswordLength) ?>
</p>
Expand All @@ -167,7 +168,7 @@
<div class="field">
<label for="confirmation" class="required"><em>*</em><?php echo $this->__('Confirm Password') ?></label>
<div class="input-box">
<input type="password" name="confirmation" title="<?php echo Mage::helper('core')->quoteEscape($this->__('Confirm Password')) ?>" id="confirmation" class="input-text required-entry validate-cpassword" />
<input type="password" name="confirmation" title="<?php echo Mage::helper('core')->quoteEscape($this->__('Confirm Password')) ?>" id="confirmation" class="input-text required-entry validate-cpassword" autocomplete="off" />
</div>
</div>
</li>
Expand Down
2 changes: 1 addition & 1 deletion app/design/frontend/default/iphone/template/customer/form/login.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
<li>
<label for="pass" class="required"><em>*</em><?php echo $this->__('Password') ?></label>
<div class="input-box">
<input type="password" name="login[password]" class="input-text required-entry validate-password min-pass-length-5" id="pass" title="<?php echo $this->__('Password') ?>" />
<input type="password" name="login[password]" class="input-text required-entry validate-password min-pass-length-5" id="pass" title="<?php echo $this->__('Password') ?>" autocomplete="off" />
</div>
</li>
<li class="note">
Expand Down
2 changes: 1 addition & 1 deletion app/design/frontend/default/iphone/template/persistent/checkout/onepage/login.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
<li>
<label for="login-password" class="required"><em>*</em><?php echo $this->__('Password') ?></label>
<div class="input-box">
<input type="password" class="input-text required-entry" id="login-password" name="login[password]" />
<input type="password" class="input-text required-entry" id="login-password" name="login[password]" autocomplete="off" />
</div>
</li>
<?php echo $this->getChildHtml('form.additional.info'); ?>
Expand Down
Loading