Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bump #2835

Merged
merged 1 commit into from
Dec 23, 2022
Merged

Version bump #2835

merged 1 commit into from
Dec 23, 2022

Conversation

fballiano
Copy link
Contributor

@fballiano fballiano commented Dec 22, 2022

Since we just merged pretty important stuff, but at the same time we need more testing-time, what about a next version like 20.1.0-rc1 and 19.5.0-rc1?

Related PRs

@github-actions github-actions bot added the Mage.php Relates to app/Mage.php label Dec 22, 2022
@fballiano fballiano mentioned this pull request Dec 22, 2022
@sreichel
Copy link
Contributor

Does upper/lower-case matter?

@sreichel
Copy link
Contributor

... but ... we have an error that sould be fixed. If its okay i'd remove latest release from packagist.org.

@fballiano
Copy link
Contributor Author

Does upper/lower-case matter?

I don't think so, I used lowercase since it was already in the sample (comment next to the "alpha/beta/rc" like)

@fballiano
Copy link
Contributor Author

... but ... we have an error that sould be fixed. If its okay i'd remove latest release from packagist.org.

but how can we fix that anyway now?
they only way would be to create a branch from the currently released tag, fix the typo manually and release that, without PRs etc..

@sreichel
Copy link
Contributor

You are doing the releases. Is it much work to make that hotfix release?

We could fix this bug w/o enforce to update to Zend-changes.

@fballiano
Copy link
Contributor Author

@sreichel in this case it's pretty easy, I've already created branch https://github.com/OpenMage/magento-lts/tree/19.4.21 with just 2 commits. they're pretty basic so everything should be ok. can you check it out a second and then I'll release?

also, it's a v19 hotfix only because v20 doesn't have the bug with #2793

@sreichel
Copy link
Contributor

Perfect.

@Flyingmana
Copy link
Contributor

... but ... we have an error that sould be fixed. If its okay i'd remove latest release from packagist.org.

be very very very careful with removing releases, this is going to break anyone who uses this in their composer.json or composer.lock.
Replacing it does not work anyway, as it would have a different checksum and cause fails.

@fballiano
Copy link
Contributor Author

We’ll not remove anything don’t worry

@sreichel
Copy link
Contributor

sreichel commented Dec 22, 2022

... but ... we have an error that sould be fixed. If its okay i'd remove latest release from packagist.org.

be very very very careful with removing releases, this is going to break anyone who uses this in their composer.json or composer.lock. Replacing it does not work anyway, as it would have a different checksum and cause fails.

Thanks. This is why i asked for.

Is there another propper way to avoid installing "bugged" releases?

Something like a required extension that cant we installed with certain releases?

Replacing it does not work anyway, as it would have a different checksum and cause fails.

I'd not re-add it. If its bugged it should be not available to install. However ... not going to touch this.

@fballiano
Copy link
Contributor Author

Tomorrow morning I’ll release the new v19 and there will be no problem anymore 😉

@fballiano
Copy link
Contributor Author

19.4.21 is released, I was afraid of the process but at the end of the day it was pretty easy and I should have done it ealier.. it's done anyway now.

@Flyingmana
Copy link
Contributor

Since we just merged pretty important stuff, but at the same time we need more testing-time, what about a next version like 20.1.0-rc1 and 19.5.0-rc1?

regarding the original question, can you link this very important stuff?
Generally I would say, releasing alpha,beta,rc releases is always okay.

But I wonder what it is, that requires the minor version bump, especially for the 19. release

@fballiano
Copy link
Contributor Author

it's the drop of CM modules and ZF1 moving them to composer

@fballiano
Copy link
Contributor Author

linkedin the PRs in the description. I think the bump should be minor, not your patch version

@Flyingmana
Copy link
Contributor

it's the drop of CM modules and ZF1 moving them to composer

I see, that surely is a good reason for a minor version bump. And also a good reason for RC Tagging.

@Flyingmana Flyingmana merged commit 0afac86 into OpenMage:1.9.4.x Dec 23, 2022
@fballiano fballiano deleted the versionbump branch December 24, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mage.php Relates to app/Mage.php
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants