Fixed passing null for trim is deprecated in Mage_Catalog_Model_Attribute_Backend_Customlayoutupdate #3336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bute_Backend_Customlayoutupdate
kiatng
reviewed
Jun 21, 2023
app/code/core/Mage/Catalog/Model/Attribute/Backend/Customlayoutupdate.php
Show resolved
Hide resolved
kiatng
approved these changes
Jun 22, 2023
fballiano
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fix
passing null to parameter #1 ($string) of type string is deprecatedfortrimwith PHP 8.1/8.2.Perhaps it's not the best way.
I get this notice when I save a simple product associated to a configurable product at store view level.
See also this discussion comment.
Contribution checklist