-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed unnecessary entries in table api-session
when using insta-login in API calls
#3477
Conversation
…in in API calls.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
we can remove a line from the phpstan baseline in order to fix the workflow |
I don't understand why PHPStan is complaining the deleted function |
it says that we've to remove that line from the baseline, since it's not triggering an error anymore |
Co-authored-by: Mohamed ELIDRISSI <67818913+elidrissidev@users.noreply.github.com>
api-session
when using insta-log…api-session
when using insta-login in API calls
…in in API calls.
Description (*)
The API session has default expiry of 3600 secs from the time of the last API call. This expiry is managed in the table
api_asession
. With the introduction of insta-login in PR #3443, the session expiry become irrelevant. This PR bypassed adding entries to the various api tables. In my test, this saves 10 to 20 mini-seconds to insta-login.Related Pull Requests
PR #3443
Fixed Issues (if relevant)
Partially fixed issue #3449.
Manual testing scenarios (*)
api_asession
with insta-login.api_asession
with "normal" login.