Type casting and minor fixes in preparation for declare strict_types=1

[luigifab]

Description

This PR allow to add <?php declare(strict_types=1); in all files of OpenMage (@sreichel in #3647). This is only the beginning.

To add it in all files, run find app/ shell/ lib/Mage/ lib/Magento/ lib/Varien/ -name "*.ph*" -type f -exec sed -i '1s/<?php/<?php declare(strict_types=1);/' {} +

Apply this PR and enjoy backend.

To cancel changes: find app/ shell/ lib/Mage/ lib/Magento/ lib/Varien/ -name "*.ph*" -type f -exec sed -i '1s/<?php declare(strict_types=1);/<?php/' {} +

OpenMage 20.2.0, PHP 7.2 / 8.3.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)
• Add yourself to contributors list

[Flyingmana]

you need to be very careful with this, there are several situations where it changes the behavior of the code

[luigifab]

Yes, I'm not sure to understand all possible impacts, but, for localhost it looks good!
And, with them, I found some critical fails of the life!

[sreichel]

there are several situations where it changes the behavior of the code

I did not see any changes in code behavoir during my tests. (not finished, but 80%) Either it works, or you see a fatal error. I think its not that hard to add strict types, its just a lot of work and manual testing. (unit tests would be nice here)

[luigifab]

Looks good, perhaps extract enhancement for error message in another PR, and add Mage::logException().
Else we can close it.

[fballiano]

I've read all the changes and, although some of them don't seem related to the PR to me (adding details on log exception) I think they could be merged, especially because this PR is not enforcing the strict_types, but it's only preparation work.

[fballiano]

Agree with @kiatng, to speed things up I've removed from this PR the code that was not related to the strict_types thing.

[fballiano]

There's only one point open to fix for this PR.

it was solved ;-)

[fballiano]

since all the comments and subsequent modification, I think this is mergeable