New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unused variables from Mage_Api_Model_Server_Handler_Abstract #3862

Merged

fballiano merged 1 commit into OpenMage:main from fballiano:uselessvariable

Apr 1, 2024

Contributor

fballiano commented Mar 1, 2024

Those two variables are unused since they're always re-set a few lines after the instanciation.


          Removed unused variables from Mage_Api_Model_Server_Handler_Abstract

4b127df

github-actions bot added the Component: Api label

kiatng approved these changes

View reviewed changes

Contributor

kiatng left a comment

It is not necessary to initialize variables in PHP however it is a very good practice.

In this case, the variables are of mixed type, so agree to remove.

fballiano merged commit 8bb7561 into OpenMage:main

17 checks passed

fballiano deleted the uselessvariable branch

April 1, 2024 05:01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels