Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fixes ENV overriding config #4258

Closed
wants to merge 25 commits into from
Closed

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Oct 8, 2024

Description (*)

Work in progress ...

  • updates tests to test agains DB
  • fixes Mage::getStoreConfig()
  • fixes override existing DB values

Broken ...

  • unittests for non-existing stores/websites (?)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Set php ENV variables ... for DDEV (to match tests)

web_environment:
    - OPENMAGE_CONFIG__DEFAULT__GENERAL__STORE_INFORMATION__NAME=ENV default
    - OPENMAGE_CONFIG__DEFAULT__GENERAL__FOO-BAR__NAME=ENV default dashes
    - OPENMAGE_CONFIG__DEFAULT__GENERAL__FOO_BAR__NAME=ENV default underscore
    - OPENMAGE_CONFIG__DEFAULT__GENERAL__ST=ENV default invalid
    - OPENMAGE_CONFIG__WEBSITES__BASE__GENERAL__STORE_INFORMATION__NAME=ENV website
    - OPENMAGE_CONFIG__WEBSITES__BASE-AT__GENERAL__STORE_INFORMATION__NAME=ENV website dashes
    - OPENMAGE_CONFIG__WEBSITES__BASE_CH__GENERAL__STORE_INFORMATION__NAME=ENV website underscore
    - OPENMAGE_CONFIG__WEBSITES__BASE__GENERAL__ST=ENV website invalid
    - OPENMAGE_CONFIG__STORES__GERMAN__GENERAL__STORE_INFORMATION__NAME=ENV store
    - OPENMAGE_CONFIG__STORES__GERMAN-AT__GENERAL__STORE_INFORMATION__NAME=ENV store dashes
    - OPENMAGE_CONFIG__STORES__GERMAN_CH__GENERAL__STORE_INFORMATION__NAME=ENV store underscore
    - OPENMAGE_CONFIG__STORES__GERMAN__GENERAL__ST=ENV store invalid

Comments

This is not nearly perfect, but may help @pquerner and others to debug.

This PR is NOT based on main-branch, but on #4236.

See ec2c8a9 for relevant changes.

@pquerner @boesbo please check.

@github-actions github-actions bot added environment Component: PayPal Relates to Mage_Paypal Component: Core Relates to Mage_Core Component: Catalog Relates to Mage_Catalog Component: Reports Relates to Mage_Reports Component: Checkout Relates to Mage_Checkout Component: lib/Varien Relates to lib/Varien Component: Sales Relates to Mage_Sales Component: Usa Relates to Mage_Usa Component: Eav Relates to Mage_Eav Component: Adminhtml Relates to Mage_Adminhtml labels Oct 8, 2024
@github-actions github-actions bot added Component: Page Relates to Mage_Page Component: Captcha Relates to Mage_Captcha Component: Admin Relates to Mage_Admin Component: Tax Relates to Mage_Tax Component: Bundle Relates to Mage_Bundle Component: Api2 Relates to Mage_Api2 Component: Rss Relates to Mage_Rss Component: lib/* Relates to lib/* composer Relates to composer.json phpstan phpunit ddev rector labels Oct 8, 2024
@sreichel
Copy link
Contributor Author

sreichel commented Oct 9, 2024

Clean PR later ...

@sreichel sreichel closed this Oct 9, 2024
@sreichel sreichel deleted the phpunit-env branch October 9, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Admin Relates to Mage_Admin Component: Adminhtml Relates to Mage_Adminhtml Component: Api2 Relates to Mage_Api2 Component: Bundle Relates to Mage_Bundle Component: Captcha Relates to Mage_Captcha Component: Catalog Relates to Mage_Catalog Component: Checkout Relates to Mage_Checkout Component: Core Relates to Mage_Core Component: Eav Relates to Mage_Eav Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: Page Relates to Mage_Page Component: PayPal Relates to Mage_Paypal Component: Reports Relates to Mage_Reports Component: Rss Relates to Mage_Rss Component: Sales Relates to Mage_Sales Component: Tax Relates to Mage_Tax Component: Usa Relates to Mage_Usa composer Relates to composer.json ddev environment phpstan phpunit rector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant