Draft for discussion: Defining intersection borders #602
Conversation
clemenshabedank
added
the
RoadModel4.0
Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp>
clemenshabedank
force-pushed
the
intersection-area-clarifications
branch
from
dace142
to
3e2a859
Compare
Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp>
Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp>
Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp>
|
Road Model Meeting: |
|
@tbleher and @rockteresa as a reminder please have a look if you regard this change necessary for the upcoming v3.5 release. |
osi_lane.proto
Outdated
| // An intersection as a lane. | ||
| // An area in the form of a polygon, where logical lanes | ||
| // of TYPE_NORMAL may overlap and typically do in parts of | ||
| // the area. |
There was a problem hiding this comment.
@clemenshabedank Könnte die Beschreibung vom Type Intersection etwas irreführend sein? Bei allen Type ist von einer "lane" die rede bei der Intersection von einer Fläche -> "The concatenated area of lanes that form the intersection"
| // LogicalLaneBoundary.LogicalBoundaryPoint with the LogicalLaneBoundary.LogicalBoundaryPoint | ||
| // of another LogicalLaneBoundary which is linked as left_lane_boundary_id or right_lane_boundary_id from a | ||
| // successor or predecessor logical lane with LogicalLane.Type = TYPE_NORMAL. | ||
| // |
There was a problem hiding this comment.
Just mentioning.. there might be undefined areas between lane and border that are not part of the polygon if using the boundaries of the drivng lanes of the intersection.
There was a problem hiding this comment.
That's true. Thought about specifying those but got away from it (see ae06ee1) because at least when converting from OpenDRIVE (and that was the starting point for the logical lanes) the gaps are meaningless because they don't tell you if those areas are drivable or not. I would wait for OpenDRIVE to solve this problem prior specifying it here.
Signed-off-by: Habedank Clemens <qxs2704@europe.bmw.corp>
Reference to a related issue in the repository
Add a reference to a related issue in the repository.
Add a description
Add a description of the changes proposed in the pull request.
Some questions to ask:
What is this change?
What does it fix?
Is this a bug fix or a feature? Does it break any existing functionality or force me to update to a new version?
How has it been tested?
Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:
If you can’t check all of them, please explain why.
If all boxes are checked or commented and you have achieved at least one positive review, you can assign the label ReadyForCCBReview!