Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add osi_control.proto #612

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add osi_control.proto #612

wants to merge 2 commits into from

Conversation

ThomasNaderBMW
Copy link
Contributor

@ThomasNaderBMW ThomasNaderBMW commented Jan 21, 2022

The new osi_control proto-file enables controlling external components.

Signed-off-by: Thomas Nader Thomas.Nader@bmw.de

Add a description

The new osi_control.proto enables controlling external components.
Examples are starting, stopping, health information from one component to another component.

Some questions to ask:
What does it fix?
When using distributed systems it is not necessary any more to implement custom interfaces or controlling them manually.
Is this a bug fix or a feature?
It's a feature!
Does it break any existing functionality or force me to update to a new version?
No as it is a new file.
How has it been tested?
Yes many times. It is used between driving simulation environments and graphic engines.

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

  • My suggestion follows the style and contributors guidelines.
  • I have taken care about the documentation.
  • I have done the DCO signoff.
  • My changes generate no errors when passing CI tests.
  • I have successfully implemented and tested my fix/feature locally.
  • Appropriate reviewer(s) are assigned.

If you can’t check all of them, please explain why.
If all boxes are checked or commented and you have achieved at least one positive review, you can assign the label ReadyForCCBReview!

The new osi_control proto-file enables controlling external components.

Signed-off-by: Thomas Nader <Thomas.Nader@bmw.de>
@ThomasNaderBMW ThomasNaderBMW added the FeatureRequest Proposals which enhance the interface or add additional features. label Jan 21, 2022
@ThomasNaderBMW ThomasNaderBMW added this to the V3.5.0 milestone Jan 21, 2022
@ThomasNaderBMW ThomasNaderBMW self-assigned this Jan 21, 2022
Deleted unit brackets

Signed-off-by: Thomas Nader <Thomas.Nader@bmw.de>
@clemenshabedank clemenshabedank modified the milestones: V3.5.0, V4.0.0 May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FeatureRequest Proposals which enhance the interface or add additional features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants