Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add France Connect Terms of Service #1518

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

OTA-Bot
Copy link
Collaborator

@OTA-Bot OTA-Bot commented Jun 29, 2024

🔎 Inspect this declaration suggestion

Bots should take care of checking the formatting and the validity of the declaration. As a human reviewer, you should check:

  • The suggested document matches the scope of this instance: it targets a service in the language, jurisdiction, and industry that are part of those described for this instance.
  • The service name France Connect matches what you see on the web page, and it complies with the guidelines.
  • The service ID France Connect (i.e. the name of the file) is derived from the service name according to the guidelines.
  • The terms type Terms of Service is appropriate for this document: if you read out loud the terms type tryptich, you can say that “this document describes how the writer commits to handle the object for its audience.
  • Selectors are:
    • stable: as much as possible, the CSS selectors are meaningful and specific (e.g. .tos-content rather than .ab23 .cK_drop > div).
    • simple: the CSS selectors do not have unnecessary specificity (e.g. if there is an ID, do not add a class or a tag).
  • Generated version is:
    • relevant: it is not just a series of links, for example.
    • readable: it is complete and not mangled.
    • clean: it does not contain navigation links, unnecessary images, or extra content.

If no document type seems appropriate for this document yet it is relevant to track in this instance, please check if there is already an open discussion about such a type and reference your case there, or open a new discussion if not.

Thanks to your work and attention, Open Terms Archive will ensure that high quality data is available for all reusers, enabling them to do their part in shifting the balance of power towards end users and regulators instead of spending time collecting and cleaning documents 💪


This suggestion has been created through the Contribution Tool, which enables graphical declaration of documents. You can load it on your local instance if you have one set up.

@OTA-Bot
Copy link
Collaborator Author

OTA-Bot commented Jun 30, 2024

🔎 Inspect the updated declaration suggestion

A new suggestion has been made, voiding the previous ones. As a human reviewer, here are the things you should check:

  • The suggested document matches the scope of this instance: it targets a service in the language, jurisdiction, and industry that are part of those described for this instance.
  • The service name FranceConnect matches what you see on the web page, and it complies with the guidelines.
  • The service ID FranceConnect (i.e. the name of the file) is derived from the service name according to the guidelines.
  • The terms type Terms of Service is appropriate for this document: if you read out loud the terms type tryptich, you can say that “this document describes how the writer commits to handle the object for its audience.
  • Selectors are:
    • stable: as much as possible, the CSS selectors are meaningful and specific (e.g. .tos-content rather than .ab23 .cK_drop > div).
    • simple: the CSS selectors do not have unnecessary specificity (e.g. if there is an ID, do not add a class or a tag).
  • Generated version is:
    • relevant: it is not just a series of links, for example.
    • readable: it is complete and not mangled.
    • clean: it does not contain navigation links, unnecessary images, or extra content.

This suggestion has been created through the Contribution Tool, which enables graphical declaration of documents. You can load it on your local instance if you have one set up.

@clementbiron clementbiron self-requested a review July 2, 2024 07:26
Copy link
Member

@clementbiron clementbiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @taniki for adding this service.

I've removed the duplicate and improved the selectors with the use of range selectors.

@clementbiron clementbiron force-pushed the add_france_connect_terms_of_service branch from 2161d40 to 489fbba Compare July 2, 2024 08:38
@clementbiron
Copy link
Member

In view of the many recent contributions regarding French public services, the core team is considering the possibility of creating a dedicated collection. It should take at most until the end of the week to work out how this could be set up. And in the meantime we're reviewing pull requests and postponing their merges. Thank you for your understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants