Detect changes and type fixes #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Sep 18, 2022
mverzilli
approved these changes
Sep 19, 2022
spalladino
reviewed
Sep 19, 2022
There was a problem hiding this comment.
LGTM, except for the type checks in _isProvided, which make me a bit nervous. Also, given that we're now removing all non-empty props, can we test that the plugin properly recognizes updates when we change something from null to non-null and vice versa? Eg setting an autotask condition or trigger for a sentinel.
spalladino
approved these changes
Sep 19, 2022
mok0230
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #25 and #26.
Check list: