Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce ERC20 allowance before triggering transfer #3056

Merged
merged 11 commits into from
Dec 31, 2021

Conversation

frangio
Copy link
Contributor

@frangio frangio commented Dec 27, 2021

This has been pointed out many times and even though it is not an issue, I think it's better to change the order to follow the general rule of failing early.

@frangio frangio requested a review from Amxx December 27, 2021 21:50
@Amxx Amxx mentioned this pull request Dec 29, 2021
3 tasks
@frangio frangio requested a review from Amxx December 29, 2021 16:24
@frangio
Copy link
Contributor Author

frangio commented Dec 29, 2021

@Amxx Your commits look good to me. Should we merge?

@Amxx Amxx enabled auto-merge (squash) December 31, 2021 09:08
@Amxx Amxx merged commit a9f994f into OpenZeppelin:master Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants