Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make VestingWallet payable to allow funding at construction #3665

Merged

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Aug 31, 2022

If PaymentSplitter's constructor is payable, then so should VestingWallet's

PR Checklist

  • Tests
  • Changelog entry

Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Amxx Amxx merged commit 4b8b92c into OpenZeppelin:master Aug 31, 2022
@Amxx Amxx deleted the feature/vestingWallet/payableConstructor branch August 31, 2022 18:19
ronhuafeng added a commit to ronhuafeng/openzeppelin-contracts that referenced this pull request Sep 9, 2022
JulissaDantes pushed a commit to JulissaDantes/openzeppelin-contracts that referenced this pull request Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants