Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge rebuy-de/aws-nuke #6

Merged
merged 13 commits into from
Apr 6, 2020
Merged

Conversation

eschwartz
Copy link

@eschwartz eschwartz commented Mar 10, 2020

Merge in rebuy-de/aws-nuke (upstream) for latest changes.

eschwartz and others added 13 commits February 6, 2020 14:04
* Upgrade to aws sdk version 1.28.12
* added eks fargate profile resource
* added eks nodegroup as resource
…ction (rebuy-de#481)

* rebuy-de#430 - cloudformation support for disabling termination protection
* Disable Security Hub

See rebuy-de#452

Add the ability to detect regions with Security Hub enabled and disable it if a
"hub" resource is returned.

* Rename property of SecurityHub hub Arn
Replace the wildcard to ** to allow recurside sublevel directories in
the nuke process.

Co-authored-by: Bruno Paiuca <bruno.paiuca@wildlifestudios.com>
@eschwartz eschwartz changed the title Merge upstream Merge rebuy-de/aws-nuke Mar 10, 2020
@eschwartz eschwartz mentioned this pull request Mar 10, 2020
@rwhelan
Copy link

rwhelan commented Mar 26, 2020

When can we expect this to get merged?

Copy link

@nathanagood nathanagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathanagood nathanagood merged commit 3378684 into Optum:master Apr 6, 2020
@rwhelan rwhelan mentioned this pull request Apr 8, 2020
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.