Skip to content

Commit

Permalink
fix(forms): add .mt-2 to all submit buttons in forms examples (#1495)
Browse files Browse the repository at this point in the history
* Make submit buttons 30px under the last input pages example

Co-authored-by: Julien Déramond <julien.deramond@orange.com>
  • Loading branch information
louismaximepiton and julien-deramond authored Nov 9, 2022
1 parent f14b551 commit 3db79a9
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 11 deletions.
4 changes: 2 additions & 2 deletions site/content/docs/5.2/components/dropdowns.md
Original file line number Diff line number Diff line change
Expand Up @@ -730,7 +730,7 @@ Put a form within a dropdown menu, or make it into a dropdown menu, and use [mar
</label>
</div>
</div>
<button type="submit" class="btn btn-primary">Sign in</button>
<button type="submit" class="btn btn-primary mt-2">Sign in</button>
</form>
<div class="dropdown-divider"></div>
<a class="dropdown-item" href="#">New around here? Sign up</a>
Expand Down Expand Up @@ -760,7 +760,7 @@ Put a form within a dropdown menu, or make it into a dropdown menu, and use [mar
</label>
</div>
</div>
<button type="submit" class="btn btn-primary">Sign in</button>
<button type="submit" class="btn btn-primary mt-2">Sign in</button>
</form>
</div>
{{< /example >}}
Expand Down
4 changes: 2 additions & 2 deletions site/content/docs/5.2/forms/layout.md
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ More complex layouts can also be created with the grid system.
</div>
</div>
<div class="col-12">
<button type="submit" class="btn btn-primary">Sign in</button>
<button type="submit" class="btn btn-primary mt-2">Sign in</button>
</div>
</form>
{{< /example >}}
Expand Down Expand Up @@ -166,7 +166,7 @@ At times, you maybe need to use margin or padding utilities to create that perfe
</div>
</div>
</div>
<button type="submit" class="btn btn-primary">Sign in</button>
<button type="submit" class="btn btn-primary mt-2">Sign in</button>
</form>
{{< /example >}}

Expand Down
6 changes: 3 additions & 3 deletions site/content/docs/5.2/forms/overview.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ Here's a quick example to demonstrate Boosted's form styles. Keep reading for do
<input type="checkbox" class="form-check-input" id="exampleCheck1">
<label class="form-check-label" for="exampleCheck1">Check me out</label>
</div>
<button type="submit" class="btn btn-primary">Submit</button>
<button type="submit" class="btn btn-primary mt-2">Submit</button>
</form>
{{< /example >}}

Expand Down Expand Up @@ -130,7 +130,7 @@ Use the `.is-disabled` class on `label` to make it appear lighter too.
</label>
</div>
</div>
<button type="submit" class="btn btn-primary">Submit</button>
<button type="submit" class="btn btn-primary mt-2">Submit</button>
</fieldset>
</form>
{{< /example >}}
Expand Down Expand Up @@ -159,7 +159,7 @@ Use the `.is-required` class on `label` to add a `*` symbol after it.
<label class="form-check-label" for="requiredFieldsetCheck">Must check this</label>
</div>
</div>
<button type="submit" class="btn btn-primary">Submit</button>
<button type="submit" class="btn btn-primary mt-2">Submit</button>
</fieldset>
</form>
{{< /example >}}
Expand Down
8 changes: 4 additions & 4 deletions site/content/docs/5.2/forms/validation.md
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ Custom feedback styles apply custom colors, borders, focus styles, and backgroun
</div>
</div>
<div class="col-12">
<button class="btn btn-primary" type="submit">Submit form</button>
<button class="btn btn-primary mt-2" type="submit">Submit form</button>
</div>
</form>
{{< /example >}}
Expand Down Expand Up @@ -156,7 +156,7 @@ While these feedback styles cannot be styled with CSS, you can still customize t
</div>
</div>
<div class="col-12">
<button class="btn btn-primary" type="submit">Submit form</button>
<button class="btn btn-primary mt-2" type="submit">Submit form</button>
</div>
</form>
{{< /example >}}
Expand Down Expand Up @@ -231,7 +231,7 @@ To fix [issues with border radius](https://github.com/twbs/bootstrap/issues/2511
</div>
</div>
<div class="col-12">
<button class="btn btn-primary" type="submit">Submit form</button>
<button class="btn btn-primary mt-2" type="submit">Submit form</button>
</div>
</form>
{{< /example >}}
Expand Down Expand Up @@ -300,7 +300,7 @@ Validation styles are available for the following form controls and components:
</div>

<div class="mb-3">
<button class="btn btn-primary" type="submit" disabled>Submit form</button>
<button class="btn btn-primary mt-2" type="submit" disabled>Submit form</button>
</div>
</form>
{{< /example >}}
Expand Down
4 changes: 4 additions & 0 deletions site/content/docs/5.2/migration.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ If you need more details about the changes, please refer to the [v5.2.2 release]
- **Modals**
- <span class="badge bg-warning">Warning</span> Modals markups have changed to show that a modal dialog represents its own separate document/context, so most of the `.modal-title`s are now `<h1>`s associated with a `.h*`. Please reflect this modification into your websites by choosing the right header level.

### Forms

- <span class="badge bg-warning">Warning</span> All forms examples have been modified to add a `.mt-2` to all submit buttons in order to always have 30px between the last form control and the button. Please reflect this modification into your websites.

## v5.2.1

<hr class="mb-4">
Expand Down

0 comments on commit 3db79a9

Please sign in to comment.