Skip to content

Commit

Permalink
style(Boosted mod): harmonize Boosted mod comments for #210
Browse files Browse the repository at this point in the history
  • Loading branch information
ffoodd committed Sep 24, 2019
1 parent 04e90bd commit 568220d
Show file tree
Hide file tree
Showing 13 changed files with 22 additions and 23 deletions.
2 changes: 1 addition & 1 deletion js/src/collapse.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ const Dimension = {
}

const Selector = {
ACTIVES : '*:not(.multi) > .show, *:not(.multi) > .collapsing', // boosted mod
ACTIVES : '*:not(.multi) > .show, *:not(.multi) > .collapsing', // Boosted mod
DATA_TOGGLE : '[data-toggle="collapse"]'
}

Expand Down
6 changes: 3 additions & 3 deletions js/src/tab.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const DATA_KEY = 'bs.tab'
const EVENT_KEY = `.${DATA_KEY}`
const DATA_API_KEY = '.data-api'
const JQUERY_NO_CONFLICT = $.fn[NAME]
// boosted mod
// Boosted mod
const ARROW_LEFT_KEYCODE = 37 // KeyboardEvent.which value for left arrow key
const ARROW_UP_KEYCODE = 38 // KeyboardEvent.which value for up arrow key
const ARROW_RIGHT_KEYCODE = 39 // KeyboardEvent.which value for right arrow key
Expand All @@ -34,7 +34,7 @@ const Event = {
SHOW : `show${EVENT_KEY}`,
SHOWN : `shown${EVENT_KEY}`,
CLICK_DATA_API : `click${EVENT_KEY}${DATA_API_KEY}`,
KEYDOWN_DATA_API : `keydown${EVENT_KEY}${DATA_API_KEY}` // boosted mod
KEYDOWN_DATA_API : `keydown${EVENT_KEY}${DATA_API_KEY}` // Boosted mod
}

const ClassName = {
Expand Down Expand Up @@ -64,7 +64,7 @@ const Selector = {
class Tab {
constructor(element) {
this._element = element
this._addAccessibility() // Boosted mod
this._addAccessibility() // Boosted mod
}

// Getters
Expand Down
4 changes: 2 additions & 2 deletions js/src/tooltip.js
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ class Tooltip {
? this.config.placement.call(this, tip, this.element)
: this.config.placement

// boosted mod let instead of const
// Boosted mod let instead of const
let attachment = this._getAttachment(placement)
this.addAttachmentClass(attachment)

Expand All @@ -292,7 +292,7 @@ class Tooltip {

$(this.element).trigger(this.constructor.Event.INSERTED)

// boosted mod fix rtl
// Boosted mod fix rtl
const dir = document.getElementsByTagName('html')[0].dir
if (dir === 'rtl') {
const hash = {
Expand Down
2 changes: 1 addition & 1 deletion scss/_alert.scss
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
top: 0;
right: 0;
padding: $alert-padding-y $alert-padding-x;
line-height: $alert-padding-y; // boosted mod
line-height: $alert-padding-y; // Boosted mod
color: inherit;
}
}
Expand Down
4 changes: 2 additions & 2 deletions scss/_breadcrumb.scss
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
display: flex;
flex-wrap: wrap;
padding: $breadcrumb-padding-y $breadcrumb-padding-x;
// boosted mod
// Boosted mod
// margin-bottom: $breadcrumb-margin-bottom;
font-size: $breadcrumb-font-size;
font-weight: $font-weight-bold;
Expand All @@ -21,7 +21,7 @@
&::before {
display: inline-block; // Suppress underlining of the separator in modern browsers
padding-right: $breadcrumb-item-padding;
// boosted mod
// Boosted mod
font-family: $breadcrumb-font-family;
font-size: $breadcrumb-divider-font-size;
line-height: 1;
Expand Down
2 changes: 1 addition & 1 deletion scss/_buttons.scss
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ fieldset:disabled a.btn {
// Alternate buttons
//

// boosted mod custom buttons
// Boosted mod : custom buttons
// @mixin button-variant($background, $border, $hover-background, $hover-border, $active-background, $active-border, $disabled-background, $disabled-border, $disabled-color, $color) {
.btn-primary,
.btn-warning {
Expand Down
2 changes: 1 addition & 1 deletion scss/_carousel.scss
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@
@include hover-focus() {
color: $carousel-control-color;
text-decoration: none;
outline: 2px dotted $input-focus-border-color; //boosted mod
outline: 2px dotted $input-focus-border-color; // Boosted mod
opacity: $carousel-control-hover-opacity;
}
}
Expand Down
4 changes: 2 additions & 2 deletions scss/_close.scss
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
line-height: 1;
color: $close-color;
text-shadow: $close-text-shadow;
opacity: 1; // boosted mod
opacity: 1; // Boosted mod

// Override <a>'s hover style
@include hover() {
Expand All @@ -15,7 +15,7 @@

&:not(:disabled):not(.disabled) {
@include hover-focus() {
opacity: 1; // boosted mod
opacity: 1; // Boosted mod
}
}
}
Expand Down
6 changes: 3 additions & 3 deletions scss/_custom-forms.scss
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@
width: $custom-switch-width;
height: $custom-switch-height; // Boosted mod
pointer-events: all;
background-color: $custom-control-indicator-border-color; // boosted mod
background-color: $custom-control-indicator-border-color; // Boosted mod
background-image: escape-svg(url("data:image/svg+xml,<svg xmlns='http://www.w3.org/2000/svg' width='20' height='20' viewBox='0 0 1250 1250'><path d='M343.625 211.5c-4.875 1.125-12 4.125-15.875 6.5-8.5 5.25-102 98.25-108.625 108-8.875 13.25-12.25 31.5-8.625 46.875C215 392.25 209.625 386.25 334.125 511l114 114-114 114.125c-113.375 113.375-114 114-118.5 123.625-5.375 11.75-6.875 18.75-6.25 30.625.5 12.125 4.375 23.375 11.375 33.5 4.125 5.875 100.25 101 105.5 104.375 13.75 8.875 33.25 11.875 48.875 7.625 17.625-4.75 14.875-2.25 136.375-123.625L625 801.875l114 114C848.875 1025.625 853.5 1030 862.25 1034.25c20.625 9.75 45.25 8.375 62.125-3.625 7.75-5.5 100.75-98.125 105.75-105.25 9.25-13.375 13.125-33.375 9.25-48.625-4.875-19.5.625-13.375-123.5-137.75l-114-114L915.75 510.875c80.75-80.75 114.875-115.75 117.25-120.125 11.5-21.125 10.25-46.75-3.125-66.375-3.875-5.75-98.625-100.625-104.25-104.5-11.125-7.5-24.5-11.25-37.875-10.5-11.875.5-21.125 3.375-30.25 9-4.5 2.875-46.125 43.625-119.625 117L625 448.125l-114-114C386.375 209.75 392.25 215 373 210.5c-10-2.25-17.625-2-29.375 1z' fill='#{$white}'/></svg>")); // Boosted mod
background-repeat: no-repeat; // Boosted mod
background-position: 1.975rem; // Boosted mod
Expand All @@ -266,7 +266,7 @@
}

&::after {
top: calc(#{(($font-size-base * $line-height-base - $custom-control-indicator-size) / 2)} + #{$custom-control-indicator-border-width}); // boosted mod
top: calc(#{(($font-size-base * $line-height-base - $custom-control-indicator-size) / 2)} + #{$custom-control-indicator-border-width}); // Boosted mod
left: $custom-control-indicator-border-width; // Boosted mod
width: $custom-switch-indicator-width; // Boosted mod
height: $custom-switch-indicator-height; // Boosted mod
Expand Down Expand Up @@ -303,7 +303,7 @@
// end mod
&::after {
background-color: $custom-control-indicator-bg;
transform: translateX($custom-switch-width / 2); // boosted mod change the indicator size
transform: translateX($custom-switch-width / 2); // Boosted mod : change the indicator size
}
}

Expand Down
2 changes: 1 addition & 1 deletion scss/_o-carousel.scss
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
cursor: pointer;
background-image: none;
background-size: 0;
//Boosted mod
// Boosted mod
&:focus {
outline: 2px dotted $input-focus-border-color;
outline-offset: -1px;
Expand Down
5 changes: 2 additions & 3 deletions scss/_o-nav.scss
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
}
}

// Boosted Mod
// Boosted ood
.o-nav-light {
padding-left: inherit;
border-bottom: 1px solid $gray-600;
Expand All @@ -23,8 +23,7 @@
color: $primary;
border-bottom: 3px solid $primary;
}

// End mod
// end mod

//
// classic tab
Expand Down
2 changes: 1 addition & 1 deletion scss/boosted.scss
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
@import "utilities";
@import "print";

// boosted mod
// Boosted mod
@import "o-card";
@import "o-switches";
@import "o-forms";
Expand Down
4 changes: 2 additions & 2 deletions scss/mixins/_forms.scss
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@
width: 100%;
margin-top: $form-feedback-margin-top;
@include font-size($form-feedback-font-size);
font-weight: $font-weight-bold; // Boosted Mod
// color: $color; // Boosted Mod
font-weight: $font-weight-bold; // Boosted mod
// color: $color; // Boosted mod
}

.#{$state}-tooltip {
Expand Down

0 comments on commit 568220d

Please sign in to comment.