Skip to content

Commit

Permalink
fix(nav+pagination+dropdown): ensure there's no unwanted underlines o…
Browse files Browse the repository at this point in the history
…n non-content links
  • Loading branch information
ffoodd committed Sep 17, 2019
1 parent 3014f23 commit 6854009
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 1 deletion.
1 change: 1 addition & 0 deletions scss/_dropdown.scss
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@
font-weight: $font-weight-normal;
color: $dropdown-link-color;
text-align: inherit; // For `<button>`s
text-decoration: none; // Boosted mod
white-space: nowrap; // prevent links from randomly breaking onto new lines
background-color: transparent; // For `<button>`s
border: 0; // For `<button>`s
Expand Down
1 change: 1 addition & 0 deletions scss/_nav.scss
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

// Boosted mod
font-weight: $font-weight-bold;
text-decoration: none;
// end mod

@include hover-focus() {
Expand Down
1 change: 1 addition & 0 deletions scss/_navbar.scss
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@
// Boosted mod
padding: .875rem .625rem;
margin-top: 0;
text-decoration: none;

&.active::before {
display: none;
Expand Down
2 changes: 2 additions & 0 deletions scss/_pagination.scss
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,11 @@
// End mod
line-height: $pagination-line-height;
color: $pagination-color;
text-decoration: none; // Boosted mod
background-color: $pagination-bg;
border: $pagination-border-width solid $pagination-border-color;


&:hover,
&:focus {
z-index: 2;
Expand Down
2 changes: 1 addition & 1 deletion scss/_reboot.scss
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ a {

// Boosted mod
p a,
main :not([class*="nav"]) > li a {
main li a {
text-decoration: underline;

@include hover-focus() {
Expand Down

0 comments on commit 6854009

Please sign in to comment.