Skip to content

Commit

Permalink
fix(quantity selector): avoid using .input-group selector to match …
Browse files Browse the repository at this point in the history
…only quantity selector in JS (#1825)
  • Loading branch information
MewenLeHo authored Feb 13, 2023
1 parent f48e896 commit 7569019
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions js/src/quantity-selector.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const EVENT_CLICK_DATA_API = `click${EVENT_KEY}${DATA_API_KEY}`
const SELECTOR_STEP_UP_BUTTON = '[data-bs-step="up"]'
const SELECTOR_STEP_DOWN_BUTTON = '[data-bs-step="down"]'
const SELECTOR_COUNTER_INPUT = '[data-bs-step="counter"]'
const SELECTOR_INPUT_GROUP = '.input-group'
const SELECTOR_QUANTITY_SELECTOR = '.input-group.quantity-selector'

/**
* Class definition
Expand Down Expand Up @@ -59,7 +59,7 @@ class QuantitySelector extends BaseComponent {

// Static
static StepUp(event) {
const parent = event.target.closest(SELECTOR_INPUT_GROUP)
const parent = event.target.closest(SELECTOR_QUANTITY_SELECTOR)
const counterInput = parent.querySelector(SELECTOR_COUNTER_INPUT)

const max = counterInput.getAttribute('max')
Expand All @@ -76,7 +76,7 @@ class QuantitySelector extends BaseComponent {
}

static StepDown(event) {
const parent = event.target.closest(SELECTOR_INPUT_GROUP)
const parent = event.target.closest(SELECTOR_QUANTITY_SELECTOR)
const counterInput = parent.querySelector(SELECTOR_COUNTER_INPUT)

const min = counterInput.getAttribute('min')
Expand All @@ -93,7 +93,7 @@ class QuantitySelector extends BaseComponent {
}

static CheckIfDisabledOnChange(event) {
const parent = event.target.closest(SELECTOR_INPUT_GROUP)
const parent = event.target.closest(SELECTOR_QUANTITY_SELECTOR)
const counterInput = parent.querySelector(SELECTOR_COUNTER_INPUT)
const btnUp = parent.querySelector(SELECTOR_STEP_UP_BUTTON)
const btnDown = parent.querySelector(SELECTOR_STEP_DOWN_BUTTON)
Expand Down Expand Up @@ -140,7 +140,7 @@ EventHandler.on(document, EVENT_CLICK_DATA_API, SELECTOR_STEP_UP_BUTTON, Quantit
EventHandler.on(document, EVENT_CLICK_DATA_API, SELECTOR_STEP_DOWN_BUTTON, QuantitySelector.StepDown)

EventHandler.on(window, EVENT_LOAD_DATA_API, () => {
for (const el of SelectorEngine.find(SELECTOR_INPUT_GROUP)) {
for (const el of SelectorEngine.find(SELECTOR_QUANTITY_SELECTOR)) {
QuantitySelector.getOrCreateInstance(el).ValueOnLoad(el)
}
})
Expand Down

0 comments on commit 7569019

Please sign in to comment.