fix(forms): .form-select sizes were wrong

Orange-OpenSource · Feb 11, 2021 · afd0b39 · afd0b39
1 parent 294e35f
commit afd0b39
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/scss/_variables.scss b/scss/_variables.scss
@@ -880,7 +880,7 @@ $input-group-addon-color:               null !default;
 $input-group-addon-bg:                  null !default;
 $input-group-addon-border-color:        null !default;
 
-$form-select-padding-y:             ($spacer / 2) - ($border-width / 2) !default;
+$form-select-padding-y:             $input-padding-y !default;
 $form-select-padding-x:             $input-padding-x !default;
 $form-select-font-family:           $input-font-family !default;
 $form-select-font-size:             $input-font-size !default;
@@ -909,7 +909,7 @@ $form-select-focus-box-shadow:    null !default;
 
 // Boosted mod: no .form-select-sm
 
-$form-select-padding-y-lg:        $input-padding-y-lg !default;
+$form-select-padding-y-lg:        $spacer / 2 !default;
 $form-select-padding-x-lg:        $input-padding-x-lg !default;
 $form-select-font-size-lg:        $input-font-size-lg !default;
 

diff --git a/scss/forms/_form-select.scss b/scss/forms/_form-select.scss
@@ -55,8 +55,9 @@
 // Boosted mod: no .form-select-sm
 
 .form-select-lg {
-  padding-top: $form-select-padding-y-lg;
+  padding-top: subtract($form-select-padding-y-lg, 1px); // Boosted mod
   padding-bottom: $form-select-padding-y-lg;
   padding-left: $form-select-padding-x-lg;
   @include font-size($form-select-font-size-lg);
+  line-height: 1.5; // Boosted mod
 }