Skip to content

Commit

Permalink
fix(accordion): Repare visual regressions
Browse files Browse the repository at this point in the history
  • Loading branch information
LE DIOURON Kevin committed Apr 1, 2021
1 parent 94e27fa commit b547626
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 9 deletions.
2 changes: 1 addition & 1 deletion CODE_OF_CONDUCT.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ This Code of Conduct applies both within project spaces and in public spaces whe

## Enforcement

Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting the project team at kevin.lediouron.ext@orange.com. The project team will review and investigate all complaints, and will respond in a way that it deems appropriate to the circumstances. The project team is obligated to maintain confidentiality with regard to the reporter of an incident. Further details of specific enforcement policies may be posted separately.
Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting the project team at mdo@getbootstrap.com. The project team will review and investigate all complaints, and will respond in a way that it deems appropriate to the circumstances. The project team is obligated to maintain confidentiality with regard to the reporter of an incident. Further details of specific enforcement policies may be posted separately.

Project maintainers who do not follow or enforce the Code of Conduct in good faith may face temporary or permanent repercussions as determined by other members of the project's leadership.

Expand Down
11 changes: 3 additions & 8 deletions scss/_accordion.scss
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
&:not(.collapsed) {
color: $accordion-button-active-color;
background-color: $accordion-button-active-bg;
box-shadow: inset 0 ($accordion-border-width * -1) 0 $accordion-border-color;

&::after {
// Boosted mod: use caret
Expand Down Expand Up @@ -57,27 +56,23 @@
}

.accordion-item {
margin-bottom: -$accordion-border-width;
background-color: $accordion-bg;
border: $accordion-border-width solid $accordion-border-color;

&:first-of-type {
@include border-top-radius($accordion-border-radius);

.accordion-button {
@include border-top-radius($accordion-inner-border-radius);
@include border-top-radius($accordion-border-radius);
}
}

// Only set a border-radius on the last item if the accordion is collapsed
&:last-of-type {
margin-bottom: 0;
@include border-bottom-radius($accordion-border-radius);
border-bottom: $accordion-border-width solid $accordion-border-color; // Boosted mod: borders are set on .accordion-header

.accordion-button {
// Only set a border-radius on the last item if the accordion is collapsed
&.collapsed {
@include border-bottom-radius($accordion-inner-border-radius);
@include border-bottom-radius($accordion-border-radius);
}
}

Expand Down

0 comments on commit b547626

Please sign in to comment.