Skip to content

Commit

Permalink
feat(css): add missing CSS vars for %offcanvas-css-vars and add som…
Browse files Browse the repository at this point in the history
…e for `.offcanvas-backdrop` (#1271)

Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
  • Loading branch information
isabellechanclou and julien-deramond authored Jul 22, 2022
1 parent 1d9b8fa commit bce7d10
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 4 deletions.
16 changes: 12 additions & 4 deletions scss/_offcanvas.scss
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@
--#{$prefix}offcanvas-border-width: #{$offcanvas-border-width};
--#{$prefix}offcanvas-border-color: #{$offcanvas-border-color};
--#{$prefix}offcanvas-box-shadow: #{$offcanvas-box-shadow};
--#{$prefix}offcanvas-zindex: #{$zindex-offcanvas}; // Boosted mod
--#{$prefix}offcanvas-title-line-height: #{$offcanvas-title-line-height}; // Boosted mod
--#{$prefix}offcanvas-transition-duration: #{$offcanvas-transition-duration}; // Boosted mod
// scss-docs-end offcanvas-css-vars
}

Expand All @@ -31,7 +34,7 @@
@include media-breakpoint-down($next) {
position: fixed;
bottom: 0;
z-index: $zindex-offcanvas;
z-index: var(--#{$prefix}offcanvas-zindex); // Boosted mod
display: flex;
flex-direction: column;
max-width: 100%;
Expand All @@ -41,7 +44,7 @@
background-clip: padding-box;
outline: 0;
@include box-shadow(var(--#{$prefix}offcanvas-box-shadow));
@include transition(transform $offcanvas-transition-duration ease-in-out);
@include transition(transform var(--#{$prefix}offcanvas-transition-duration) ease-in-out); // Boosted mod

&.offcanvas-start {
top: 0;
Expand Down Expand Up @@ -114,7 +117,12 @@
}

.offcanvas-backdrop {
@include overlay-backdrop($zindex-offcanvas-backdrop, $offcanvas-backdrop-bg, $offcanvas-backdrop-opacity);
// scss-docs-start offcanvas-backdrop-css-vars
--#{$prefix}offcanvas-backdrop-bg: #{$offcanvas-backdrop-bg}; // Boosted mod
--#{$prefix}offcanvas-backdrop-opacity: #{$offcanvas-backdrop-opacity}; // Boosted mod
--#{$prefix}offcanvas-backdrop-zindex: #{$zindex-offcanvas-backdrop}; // Boosted mod
// scss-docs-end offcanvas-backdrop-css-vars
@include overlay-backdrop(var(--#{$prefix}offcanvas-backdrop-zindex), var(--#{$prefix}offcanvas-backdrop-bg), var(--#{$prefix}offcanvas-backdrop-opacity)); // Boosted mod
}

.offcanvas-header {
Expand All @@ -133,7 +141,7 @@

.offcanvas-title {
margin-bottom: 0;
line-height: $offcanvas-title-line-height;
line-height: var(--#{$prefix}offcanvas-title-line-height); // Boosted mod
}

.offcanvas-body {
Expand Down
4 changes: 4 additions & 0 deletions site/content/docs/5.2/components/offcanvas.md
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,10 @@ As part of Bootstrap's evolving CSS variables approach, offcanvas now uses local

{{< scss-docs name="offcanvas-css-vars" file="scss/_offcanvas.scss" >}}

Customization of the offcanvas backdrop visibility through CSS variables can be seen on the `.offcanvas-backdrop` modifier class where we override specific values without adding duplicate CSS selectors.

{{< scss-docs name="offcanvas-backdrop-css-vars" file="scss/_offcanvas.scss" >}}

### Sass variables

{{< scss-docs name="offcanvas-variables" file="scss/_variables.scss" >}}
Expand Down

0 comments on commit bce7d10

Please sign in to comment.