Skip to content

Commit

Permalink
Merge branch 'main' into main-his-tooltip-a11y
Browse files Browse the repository at this point in the history
  • Loading branch information
julien-deramond authored Jun 12, 2023
2 parents 0887ebb + ba3cc7b commit eb65b7e
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 8 deletions.
3 changes: 1 addition & 2 deletions site/content/docs/5.3/components/orange-navbar.md
Original file line number Diff line number Diff line change
Expand Up @@ -356,8 +356,7 @@ You can add a search input into your Global header.
...

<!-- Navbar with action icons -->
<form class="d-flex d-none d-lg-flex nav-item" role="search">
<!-- todo : reforge when .dark-input -->
<form class="d-flex d-none d-lg-flex col-3 navbar-item" role="search">
<input class="form-control bg-transparent text-white border border-2 border-dark" type="search" placeholder="Search" aria-label="Search">
</form>
<div id="global-header-5.2" class="navbar-collapse collapse d-sm-flex global-header-5">
Expand Down
9 changes: 4 additions & 5 deletions site/content/docs/5.3/migration.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ Learn more by reading the new [color modes documentation]({{< docsref "/customiz

- **Alert**
- Alert variants are now styled via CSS variables.

- <span class="badge bg-warning">Deprecated</span> The `.alert-variant()` mixin is now deprecated. We now [use a Sass loop]({{< docsref "/components/alerts#sass-loops" >}}) directly to modify the component's default CSS variables for each variant.

- **Buttons**
Expand All @@ -74,6 +73,10 @@ Learn more by reading the new [color modes documentation]({{< docsref "/customiz
- The examples in our docs are now explicitly initialized and mostly don't use anymore `data-bs-ride`. Depending on how carousels are used in your project, it might need some updates.
- <span class="badge bg-danger">Breaking</span> The pause/play button is now included within the carousel for a better rendering but still respecting accessibility guidelines; it is now placed on the left-hand side of the indicators. The HTML markup has changed, please use this new version on your websites.

- **Footer**
- <span class="badge bg-warning">Warning</span> For accessibility reasons, having a `aria-labelledby` on the collapse element in the accordions used in footer is not necessary and can be removed. Be careful to not remove the corresponding `id` if used for other purposes. Please reflect these modifications into your websites.
- <span class="badge bg-success">New</span> An active link selector has been added for accessibility purpose. It might be a useful modification to propagate into your websites if you have this same kind of footer navigation.

- **List group**
- List group item variants are now styled via CSS variables.

Expand All @@ -89,10 +92,6 @@ Learn more by reading the new [color modes documentation]({{< docsref "/customiz

It also means that the "Nested tabs" variant has been slightly modified to use this new class rather than `.nav-tabs` combined to `.nav-tabs-light`.

- **Footer**
- <span class="badge bg-warning">Warning</span> For accessibility reasons, having a `aria-labelledby` on the collapse element in the accordions used in footer is not necessary and can be removed. Be careful to not remove the corresponding `id` if used for other purposes. Please reflect these modifications into your websites.
- <span class="badge bg-success">New</span> An active link selector has been added for accessibility purpose. It might be a useful modification to propagate into your websites if you have this same kind of footer navigation.

- **Progress bars**
- The markup for [progress bars]({{< docsref "/components/progress" >}}) has been updated in v5.3.0. Due to the placement of `role` and various `aria-` attributes on the inner `.progress-bar` element, **some screen readers were not announcing zero value progress bars**. Now, `role="progressbar"` and the relevant `aria-*` attributes are on the outer `.progress` element, leaving the `.progress-bar` purely for the visual presentation of the bar and optional label.

Expand Down
1 change: 0 additions & 1 deletion site/layouts/shortcodes/orange-global-headers.html
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ <h1 class="title">Title</h1>
{{- end }}
{{- if eq $mode "search" }}
<form class="d-flex d-none d-lg-flex col-3 navbar-item" role="search">
<!-- todo : reforge when .dark-input -->
<input class="form-control bg-transparent text-white border border-2 border-dark" type="search" placeholder="Search" aria-label="Search">
</form>
{{- end }}
Expand Down

0 comments on commit eb65b7e

Please sign in to comment.