Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs - invalid preload in starter template #735

Closed
Lausselloic opened this issue Jul 15, 2021 · 1 comment · Fixed by #736 or #738
Closed

Docs - invalid preload in starter template #735

Lausselloic opened this issue Jul 15, 2021 · 1 comment · Fixed by #736 or #738
Labels
backport-to-v4 bug v5

Comments

@Lausselloic
Copy link
Member

In starter template the preload for font-familly is not valid when using cdn
https://boosted.orange.com/docs/5.0/getting-started/introduction/#starter-template

Don't know what to mention, let it as a comment as it's a good practice if loading it from local dist folder

image
@Lausselloic
Copy link
Member Author

thanks @Paulintgl

julien-deramond added a commit that referenced this issue Jul 16, 2021
@julien-deramond
fix(#735): separate local fonts from CDN in the starter template
76be6b7
@julien-deramond julien-deramond mentioned this issue Jul 16, 2021
Merged
3 tasks
@julien-deramond julien-deramond linked a pull request Jul 16, 2021 that will close this issue
fix(#735): separate local fonts from CDN in the starter template #736
Merged
3 tasks
julien-deramond added a commit that referenced this issue Jul 16, 2021
@julien-deramond
fix(#735): separate local fonts from CDN in the starter template
bd18ebd
julien-deramond added a commit that referenced this issue Jul 16, 2021
@julien-deramond
fix(#735): separate local fonts from CDN in the starter template
fcbafea
julien-deramond added a commit that referenced this issue Jul 16, 2021
@julien-deramond
fix(#735): separate local fonts from CDN in the starter template
a3be86a
@julien-deramond julien-deramond linked a pull request Jul 16, 2021 that will close this issue
fix(#735): separate local fonts from CDN in the starter template #738
Merged
julien-deramond added a commit that referenced this issue Jul 16, 2021
@julien-deramond
fix(#735): separate local fonts from CDN in the starter template
a96a7dc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backport-to-v4 bug v5
Projects
None yet
Milestone
No milestone
2 participants
@Lausselloic @julien-deramond