Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components with dark background from v4 #917

Closed
7 tasks done
julien-deramond opened this issue Nov 19, 2021 · 3 comments
Closed
7 tasks done

Components with dark background from v4 #917

julien-deramond opened this issue Nov 19, 2021 · 3 comments

Comments

@julien-deramond
Copy link
Member

julien-deramond commented Nov 19, 2021

Components with dark background are needed in Boosted.
This story is a 2-steps story:

Some stories probably linked:

@julien-deramond julien-deramond added this to the Sprint 5 milestone Nov 19, 2021
@louismaximepiton louismaximepiton mentioned this issue Nov 22, 2021
11 tasks
@MewenLeHo
Copy link
Contributor

MewenLeHo commented Dec 16, 2021

After the meeting made today around #957, we agreed that :

  • there are so many solutions to do to that.
  • We may have find the best solution but we need more time to figure out exactly how to implement it correctly.
  • We can't take the risk to do something before Bootstrap. If we take a different decision the gap between Bootstrap and Boosted will be too bid and Boosted will become more difficult to maintain since merging the code may become painful.

So we decided to keep tracks of everything (including the specific discussion channel and the branch) and to keep an eye on this feature in the next version of Boostrap.

By then we are more than welcome to offer our help, take part at the discussion, test a new idea,...

@julien-deramond julien-deramond modified the milestones: Sprint 5, Sprint 6 Dec 20, 2021
@julien-deramond julien-deramond mentioned this issue Jan 7, 2022
20 tasks
@julien-deramond julien-deramond removed this from the Sprint 7 milestone Feb 2, 2022
@ffoodd
Copy link
Contributor

ffoodd commented Feb 17, 2022

Great to see this finally happening 🎉

FYI Mark started something based on custom properties and data-theme attribute: only a draft for now but I suggest you have a look at it and maybe wait for Bootstrap's implementation?

Anyway, I really hope you'll take some time to review their draft and make some useful comments, since you already have some experience around dark theme :)

@julien-deramond
Copy link
Member Author

The components planned for this user story has been developed. If needed we will open up a new issue to track the new dark variant needed in Boosted.

@ffoodd I keep in mind your comment and I'll take some time to review the draft about data-theme. I already looked at it very quickly: it looks promising!!

@julien-deramond julien-deramond changed the title Components with dark background Components with dark background from v4 Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants