Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): make visible 'Design guidelines' menu item when the page is active #1083

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Feb 1, 2022

Going onto Orange Design System for web page make it active (and visible) in the menu bar.

Screenshot from 2022-02-01 14-40-54

If you do the same thing locally with the actual main branch, the menu item won't be active.

@julien-deramond julien-deramond added v5 docs Improvements or additions to documentation fix labels Feb 1, 2022
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good for me.

@julien-deramond julien-deramond merged commit 1849be7 into main Feb 3, 2022
@julien-deramond julien-deramond deleted the main-jd-fix-display-active-menu-bar-for-design-guidelines branch February 3, 2022 06:15
@julien-deramond julien-deramond mentioned this pull request Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation fix v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants