Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forms): change the margin left value between the required symbol and the label #1144

Merged
merged 1 commit into from
Apr 1, 2022

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Mar 9, 2022

This PR is a proposal to modify the margin left value between the required symbol (the *) and the corresponding label.

The current value in Boosted is 6px: https://boosted.orange.com/docs/5.1/forms/overview/#required-field.

Screenshot from 2022-03-09 11-47-56

The value defined in the DSM is 3px.

Preview of the modification (@CyriaqueBillard I let you check the rendering and tell us if it sounds good to you)

Screenshot from 2022-03-09 11-52-58

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@julien-deramond julien-deramond force-pushed the main-jd-fix-label-required-margin-left-value branch from e997505 to f7f35cd Compare April 1, 2022 07:45
@julien-deramond julien-deramond merged commit 263c0d5 into main Apr 1, 2022
@julien-deramond julien-deramond deleted the main-jd-fix-label-required-margin-left-value branch April 1, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants